jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8290966: G1: Record number of PLAB filled and number of direct allocations

Open benty-amzn opened this issue 1 year ago • 5 comments
trafficstars

Clean, low risk backport of a change to improve logging around full PLABs and direct allocations.

Passes the included test, as well as make test TEST=gc/g1 locally on linux x64.


Progress

  • [ ] JDK-8290966 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8290966: G1: Record number of PLAB filled and number of direct allocations (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2777/head:pull/2777
$ git checkout pull/2777

Update a local copy of the PR:
$ git checkout pull/2777
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2777

View PR using the GUI difftool:
$ git pr show -t 2777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2777.diff

Webrev

Link to Webrev Comment

benty-amzn avatar Aug 02 '24 21:08 benty-amzn

:wave: Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 02 '24 21:08 bridgekeeper[bot]

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290966: G1: Record number of PLAB filled and number of direct allocations

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 37726c5f283248d5f7a827cd45be58168fc2a7e2: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa75681fbc83d6a744ae2a22f7c149dc66da5d: 8317112: Add screenshot for Frame/DefaultSizeTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 02 '24 21:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 02 '24 21:08 openjdk[bot]

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 02 '24 21:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 02 '24 21:08 mlbridge[bot]

/approval request Clean, low risk backport of a change to improve GC logging around full PLABs and direct allocations.

benty-amzn avatar Aug 05 '24 19:08 benty-amzn

@benty-amzn 8290966: The approval request has been created successfully.

openjdk[bot] avatar Aug 05 '24 19:08 openjdk[bot]

/integrate

benty-amzn avatar Aug 07 '24 18:08 benty-amzn

Going to push as commit f07c266489dd13a9c80a8fd4ad4edb51111a1d86. Since your change was applied there have been 8 commits pushed to the master branch:

  • 7a53368b2b27585270184316c9b30a6fb27e33e6: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262
  • 966cafcd14e425061a79e0027dc5ac02c968f270: 7026262: HttpServer: improve handling of finished HTTP exchanges
  • 396e209feb58c81d4271010c5c4c3fd605a1f653: 8337669: [17u] Backport of JDK-8284047 missed to delete a file
  • 7230bafbb2124b7169de7819cfcbf4981cd38404: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
  • ae7be19a7f14aec3af69d2db1509bf7f6d793f35: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 1f14f86087d4da6bad981f53f309e8d9da31f5d0: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • 37726c5f283248d5f7a827cd45be58168fc2a7e2: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa75681fbc83d6a744ae2a22f7c149dc66da5d: 8317112: Add screenshot for Frame/DefaultSizeTest.java

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 07 '24 18:08 openjdk[bot]

@benty-amzn Pushed as commit f07c266489dd13a9c80a8fd4ad4edb51111a1d86.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 07 '24 18:08 openjdk[bot]