jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8295087: Manual Test to Automated Test Conversion

Open amosshi opened this issue 1 year ago • 8 comments
trafficstars

Backport of JDK-8295087

  • This PR contains two commit
    • Commit 1 is generated by git apply from original commit
    • Commit 2 is adding the missing test case InconsistentEntries.java, which was originally added by JDK-8286779

Testing

  • Local: Test passed on MacOS 14.5 on Apple M1 Max
    • ExtDirs.java: Test results: passed: 2
    • ExtDirsChange.java: Test results: passed: 1
    • ExtDirsDefaultPolicy.java: Test results: passed: 4
    • InconsistentEntries.java: Test results: passed: 1
  • Pipeline:
    • Linux, Windows - Passed
    • MacOS - Skipped (This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.)
  • Testing Machine: SAP nightlies Passed on 2024-08-07
    • Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00
      • java/lang/ClassLoader/ExtDirs.java: SUCCESSFUL GitHub 📊 - [20:37:45.782 -> 568 msec]
    • Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00
      • sun/security/provider/PolicyParser/ExtDirsChange.java: SUCCESSFUL GitHub 📊 - [21:41:01.101 -> 364 msec]
      • sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id0: SUCCESSFUL GitHub 📊 - [21:41:01.165 -> 39 msec]
      • sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id1: SUCCESSFUL GitHub 📊 - [21:41:01.204 -> 309 msec]
      • sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id2: SUCCESSFUL GitHub 📊 - [21:41:01.465 -> 309 msec]
      • sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id3: SUCCESSFUL GitHub 📊 - [21:41:01.513 -> 362 msec]
      • javax/crypto/CryptoPermissions/InconsistentEntries.java: SUCCESSFUL GitHub 📊 - [21:30:11.979 -> 4,379 msec]

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8295087 needs maintainer approval

Issue

  • JDK-8295087: Manual Test to Automated Test Conversion (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2774/head:pull/2774
$ git checkout pull/2774

Update a local copy of the PR:
$ git checkout pull/2774
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2774/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2774

View PR using the GUI difftool:
$ git pr show -t 2774

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2774.diff

Webrev

Link to Webrev Comment

amosshi avatar Aug 02 '24 03:08 amosshi