jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8337669: [17u] Backport of JDK-8284047 missed to delete a file

Open RealCLanger opened this issue 1 year ago • 4 comments
trafficstars

The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8337669 needs maintainer approval

Issue

  • JDK-8337669: [17u] Backport of JDK-8284047 missed to delete a file (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2767/head:pull/2767
$ git checkout pull/2767

Update a local copy of the PR:
$ git checkout pull/2767
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2767/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2767

View PR using the GUI difftool:
$ git pr show -t 2767

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2767.diff

Webrev

Link to Webrev Comment

RealCLanger avatar Aug 01 '24 14:08 RealCLanger

:wave: Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 01 '24 14:08 bridgekeeper[bot]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337669: [17u] Backport of JDK-8284047 missed to delete a file

Reviewed-by: mbaesken, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • ae7be19a7f14aec3af69d2db1509bf7f6d793f35: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 1f14f86087d4da6bad981f53f309e8d9da31f5d0: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • 37726c5f283248d5f7a827cd45be58168fc2a7e2: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa75681fbc83d6a744ae2a22f7c149dc66da5d: 8317112: Add screenshot for Frame/DefaultSizeTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 01 '24 14:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 01 '24 14:08 mlbridge[bot]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 01 '24 14:08 openjdk[bot]

Oh, thanks for fixing this!

GoeLin avatar Aug 07 '24 07:08 GoeLin

/integrate

RealCLanger avatar Aug 07 '24 14:08 RealCLanger

Going to push as commit 396e209feb58c81d4271010c5c4c3fd605a1f653. Since your change was applied there have been 5 commits pushed to the master branch:

  • 7230bafbb2124b7169de7819cfcbf4981cd38404: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
  • ae7be19a7f14aec3af69d2db1509bf7f6d793f35: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 1f14f86087d4da6bad981f53f309e8d9da31f5d0: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • 37726c5f283248d5f7a827cd45be58168fc2a7e2: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa75681fbc83d6a744ae2a22f7c149dc66da5d: 8317112: Add screenshot for Frame/DefaultSizeTest.java

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 07 '24 14:08 openjdk[bot]

@RealCLanger Pushed as commit 396e209feb58c81d4271010c5c4c3fd605a1f653.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 07 '24 14:08 openjdk[bot]