jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices

Open amosshi opened this issue 1 year ago • 6 comments
trafficstars

Backport of JDK-8313674

  • Unclean backport
  • Manually merged based original commit

Testing

  • Local: will do on a Linux (os.family == "linux") - current dev machine is MacOS cannot execute for now
  • Pipeline:
  • Testing Machine:

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8313674 needs maintainer approval

Issue

  • JDK-8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2756/head:pull/2756
$ git checkout pull/2756

Update a local copy of the PR:
$ git checkout pull/2756
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2756

View PR using the GUI difftool:
$ git pr show -t 2756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2756.diff

Webrev

Link to Webrev Comment

amosshi avatar Jul 31 '24 21:07 amosshi