jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8335536: Fix assertion failure in IdealGraphPrinter when append is true

Open MaxXSoft opened this issue 1 year ago • 11 comments
trafficstars

Hi all,

This pull request contains a backport of commit 6db4c6a7 from the openjdk/jdk repository.

The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein.

The original patch does not apply cleanly to 17u due to some merge conflicts about creating xmlStream with placement new expressions.

Thanks!


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] JDK-8335536 needs maintainer approval
  • [x] Commit message must refer to an issue

Issue

  • JDK-8335536: Fix assertion failure in IdealGraphPrinter when append is true (Bug - P5 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2657/head:pull/2657
$ git checkout pull/2657

Update a local copy of the PR:
$ git checkout pull/2657
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2657

View PR using the GUI difftool:
$ git pr show -t 2657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2657.diff

Webrev

Link to Webrev Comment

MaxXSoft avatar Jul 04 '24 03:07 MaxXSoft