jdk17u-dev
jdk17u-dev copied to clipboard
8331331: :tier1 target explanation in doc/testing.md is incorrect
Hi,
This is backport of JDK-8331331. The doc/testing.html can not backport cleanly because of it's a prefixed patch JDK-8295663.
$ make CONF=linux-x86_64-server-release -n test-tier1 &> test-tier1.log $ grep "Running test " test-tier1.log Running test 'jtreg:test/hotspot/jtreg:tier1' Running test 'jtreg:test/jdk:tier1' Running test 'jtreg:test/langtools:tier1' Running test 'jtreg:test/jaxp:tier1' Running test 'jtreg:test/lib-test:tier1'
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8331331 needs maintainer approval
Issue
- JDK-8331331: :tier1 target explanation in doc/testing.md is incorrect (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2447/head:pull/2447
$ git checkout pull/2447
Update a local copy of the PR:
$ git checkout pull/2447
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2447/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2447
View PR using the GUI difftool:
$ git pr show -t 2447
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2447.diff
Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@sendaoYan This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8331331: :tier1 target explanation in doc/testing.md is incorrect
Reviewed-by: mbaesken
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 184 new commits pushed to the master branch:
- 379a14bb49f9445d384c9fa5f8e4804804a7ee22: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
- 313a7e09b12b54c364fc6ceb5315da365b2ba30b: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
- 4e702a40432d2259e139652328398ce51b9f97fd: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
- a4a0a82dc0720cc4372a90bc2cb0884525da3633: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'
- 3bdbf49bb98224c4d2664881bd8b2ef46e691d35: 8298809: Clean up vm/compiler/InterfaceCalls JMH
- 107010051fae72b0383a4c38e5b162bb07bac75d: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
- acff32c3ea372eb0a25edd92f8944d733802d2d0: 8328896: Fontmetrics for large Fonts has zero width
- 445aba4eccedd067a035a6fffeee29b8723b7687: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
- 5b43be27c310c353445b56eb881fbc55341a37fa: 8317372: Refactor some NumberFormat tests to use JUnit
- 719f9cebb32802abfc0a8dc4a9c1fc82706765ac: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
- ... and 174 more: https://git.openjdk.org/jdk17u-dev/compare/68a2d93588b1b3cdf1a8c8eb135581ede97c8ac3...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
This backport pull request has now been updated with issue from the original commit.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Only change the guide doc files, no risk.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval request Backport to correct the document description, only change the guide doc files, no risk.
@sendaoYan 8331331: The approval request has been created successfully.
Thanks for the review.
Thanks for the approved. /integrate
@sendaoYan Your change (at version 085e294aba142a87106da9573c19975d49a4f5f1) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit 83a5a4d9477b975a55490ab620a213ce00648267.
Since your change was applied there have been 186 commits pushed to the master branch:
- dc3abeee7e2f91ad03fbad9f111dd7ccceea25b4: 8309241: ClassForNameLeak fails intermittently as the class loader hasn't been unloaded
- b555bbbe0ae5b6ed653dc11d87c25dc5097b5e11: 8294691: dynamicArchive/RelativePath.java is running other test case
- 379a14bb49f9445d384c9fa5f8e4804804a7ee22: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
- 313a7e09b12b54c364fc6ceb5315da365b2ba30b: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
- 4e702a40432d2259e139652328398ce51b9f97fd: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
- a4a0a82dc0720cc4372a90bc2cb0884525da3633: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'
- 3bdbf49bb98224c4d2664881bd8b2ef46e691d35: 8298809: Clean up vm/compiler/InterfaceCalls JMH
- 107010051fae72b0383a4c38e5b162bb07bac75d: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
- acff32c3ea372eb0a25edd92f8944d733802d2d0: 8328896: Fontmetrics for large Fonts has zero width
- 445aba4eccedd067a035a6fffeee29b8723b7687: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
- ... and 176 more: https://git.openjdk.org/jdk17u-dev/compare/68a2d93588b1b3cdf1a8c8eb135581ede97c8ac3...master
Your commit was automatically rebased without conflicts.
@MBaesken @sendaoYan Pushed as commit 83a5a4d9477b975a55490ab620a213ce00648267.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
Thanks for the sponsor.