jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed

Open GoeLin opened this issue 1 year ago • 3 comments
trafficstars

I omit the test from this change. The test heavily depends on features only available in 21. I tried to get it working in 20 because that has virtual threads, but there are more things missing.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8280113 needs maintainer approval

Issue

  • JDK-8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2445/head:pull/2445
$ git checkout pull/2445

Update a local copy of the PR:
$ git checkout pull/2445
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2445

View PR using the GUI difftool:
$ git pr show -t 2445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2445.diff

GoeLin avatar May 03 '24 14:05 GoeLin

:wave: Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 03 '24 14:05 bridgekeeper[bot]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 97cc17719d01122399d1d5ea9bed02af321b27e6: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • e552509bcbbba5562219355841cf3dedd7daaeb8: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • 5a3c668646c363f2a2028e4aede63eef524ad5fd: 8272315: Improve assert_different_registers
  • e97489774f0b893ed173be05e5d848ee2af76775: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
  • d2982c673053bdea8bc122230a4d57eda76832ef: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11
  • 68a2d93588b1b3cdf1a8c8eb135581ede97c8ac3: 8330094: RISC-V: Save and restore FRM in the call stub
  • 32bf1f4169fd07291d608323c143832ad48e531e: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 03 '24 14:05 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar May 03 '24 14:05 openjdk[bot]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar May 08 '24 08:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 08 '24 08:05 mlbridge[bot]

/integrate

GoeLin avatar May 10 '24 09:05 GoeLin

Going to push as commit 4504b16390fc8c00542fdc43625e0e03a8cbc7c7. Since your change was applied there have been 7 commits pushed to the master branch:

  • 97cc17719d01122399d1d5ea9bed02af321b27e6: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • e552509bcbbba5562219355841cf3dedd7daaeb8: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • 5a3c668646c363f2a2028e4aede63eef524ad5fd: 8272315: Improve assert_different_registers
  • e97489774f0b893ed173be05e5d848ee2af76775: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
  • d2982c673053bdea8bc122230a4d57eda76832ef: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11
  • 68a2d93588b1b3cdf1a8c8eb135581ede97c8ac3: 8330094: RISC-V: Save and restore FRM in the call stub
  • 32bf1f4169fd07291d608323c143832ad48e531e: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 10 '24 09:05 openjdk[bot]

@GoeLin Pushed as commit 4504b16390fc8c00542fdc43625e0e03a8cbc7c7.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 10 '24 09:05 openjdk[bot]