jdk17u-dev
jdk17u-dev copied to clipboard
openjdk
8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
Hi, This is backport of JDK-8290023 and JDK-8290269, this PR is prefixed PR of backport JDK-8293503
Only change the testcase, additional testing:
- [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 release build
- [x] jtreg tier1/tier2/tier3 etc. tests on linux x64 fastdebug build
- [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 release build
- [x] jtreg tier1/tier2/tier3 etc. tests on linux aarch64 fastdebug build
It's not clean backport:
- test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR
8210708before8290023jdk20 - There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev
- test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported
8298073and8241293after8290023in jdk17u-dev - test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR
8284161before8290023in jdk20
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8290269 needs maintainer approval
- [ ] JDK-8290023 needs maintainer approval
Issues
- JDK-8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests (Enhancement - P4)
- JDK-8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023 (Bug - P4)
Reviewers
- Paul Hohensee (@phohensee - Reviewer) 🔄 Re-review required (review applies to 98df7caf)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438
$ git checkout pull/2438
Update a local copy of the PR:
$ git checkout pull/2438
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2438/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2438
View PR using the GUI difftool:
$ git pr show -t 2438
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2438.diff
Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
Webrevs
- 07: Full - Incremental (4e0213bc)
- 06: Full - Incremental (98df7caf)
- 05: Full - Incremental (7bdea889)
- 04: Full - Incremental (c4925b12)
- 03: Full - Incremental (7e86a2fb)
- 02: Full - Incremental (a0e75cb0)
- 01: Full - Incremental (13b8a714)
- 00: Full (62282790)
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval request Backport to remove unnecessary use of IgnoreUnrecognizedVMOptions in gc tests, test fix only, the change has been verified, no risk.
Hi Sendao, please only label for approval if you have a review. I will only approve reviewed changes, but there is no way I can filter for this. So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time. I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there. Thanks.
@sendaoYan 8290023: The approval request has been cancelled successfully.
Hi Sendao, please only label for approval if you have a review. I will only approve reviewed changes, but there is no way I can filter for this. So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time. I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there. Thanks.
Sorry for that. I will cancel approval of all the PRs which have not been review yet. Sorry.
Please remove copyright date updates that are not in the original commit, and use the latest copyright dates from the original commit rather than 2024.
Thanks for the review. The copyright mis-updates has been reverted.
⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
Thank you. Ltgm.
In JDK-8290023, there is a typo bug, which has been fixed by JDK-8290269, I think we should include backport of JDK-8290269 in this PR, the backport commit is 4e02. Can you review this PR again, thanks.
@sendaoYan
Adding additional issue to issue list: 8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!