8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN

[sendaoYan]

trafficstars

Hi, Backport of JDK-8293503, to fix the intermittent failure of TestMetaspacePerfCounters.java. This PR add a proper barrier inbetween two measurements. Only change the testcase, the change has been verify on below binary:

• [x] linux x64 release
• [x] linux x64 fastdebug
• [x] linux x86 release
• [x] linux x86 fastdebug

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8293503 needs maintainer approval

Issue

• JDK-8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2431/head:pull/2431
$ git checkout pull/2431

Update a local copy of the PR:
$ git checkout pull/2431
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2431

View PR using the GUI difftool:
$ git pr show -t 2431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2431.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (fe16685c)
• 00: Full (8cce5c8d)

[tstuefe]

Since this is not a clean backport, which part of it is not clean?

[sendaoYan]

Since this is not a clean backport, which part of it is not clean?

@tstuefe Hello

There are two part of it's not clean:

1. Before JDK-8293503, this file has prefixed PR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests, it remove jvm option -XX:+IgnoreUnrecognizedVMOptions, and split all the test config to 32 bit and 64 bit, because 32bit jvm doesn't support option -XX:-UseCompressedClassPointers. Maybe I should backport this patch before backport of JDK-8293503, or ignore this patch? I think this patch is useful.
2. The original JDK-8293503 delete gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 8293503 generic-all in test/hotspot/jtreg/ProblemList.txt. It's not needed to to in jdk17u-dev.

[sendaoYan]

Since this is not a clean backport, which part of it is not clean?

@tstuefe Hello

There are two part of it's not clean:

1. Before JDK-8293503, this file has prefixed PR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests, it remove jvm option -XX:+IgnoreUnrecognizedVMOptions, and split all the test config to 32 bit and 64 bit, because 32bit jvm doesn't support option -XX:-UseCompressedClassPointers. Maybe I should backport this patch before backport of JDK-8293503, or ignore this patch? I think this patch is useful.
2. The original JDK-8293503 delete gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 8293503 generic-all in test/hotspot/jtreg/ProblemList.txt. It's not needed to to in jdk17u-dev.

I creat a new PR for the prefixed backport JDK-8290023

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Wait until https://github.com/openjdk/jdk17u-dev/pull/2438 has been merged.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Wait until https://github.com/openjdk/jdk17u-dev/pull/2438 has been merged.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Wait https://github.com/openjdk/jdk17u-dev/pull/2438