jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit

Open shipilev opened this issue 1 year ago • 7 comments
trafficstars

WIP.

The backport is not clean because:

  1. The hunk in macro.cpp does not apply to JDK 21, because it was added later with JDK-8287061
  2. The @Arguments style in IR test does not work in JDK 21, because the API was added later with JDK-8324641
  3. The definitions for Membar nodes for IR tests were in different format.

Additional testing:

  • [x] New benchmark improves
  • [x] New IR test passes with the fix, fails without it
  • [x] Linux AArch64 server fastdebug, all
  • [x] Linux x86_64 server fastdebug, all
  • [x] Linux AArch64 server fastdebug, Maven CTW and Fuzzer tests
  • [x] Linux x86_64 server fastdebug, Maven CTW and Fuzzer tests

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8300148 needs maintainer approval

Issue

  • JDK-8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2426/head:pull/2426
$ git checkout pull/2426

Update a local copy of the PR:
$ git checkout pull/2426
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2426

View PR using the GUI difftool:
$ git pr show -t 2426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2426.diff

shipilev avatar Apr 24 '24 19:04 shipilev

:wave: Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 24 '24 19:04 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Apr 24 '24 19:04 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Apr 24 '24 19:04 openjdk[bot]

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 19 '24 21:06 bridgekeeper[bot]

Not now, bot.

shipilev avatar Jun 20 '24 07:06 shipilev

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 15 '24 10:08 bridgekeeper[bot]

Not now, bot.

shipilev avatar Aug 15 '24 18:08 shipilev

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 11 '24 00:10 bridgekeeper[bot]