jdk17u-dev
jdk17u-dev copied to clipboard
8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit
WIP.
The backport is not clean because:
- The hunk in
macro.cppdoes not apply to JDK 21, because it was added later with JDK-8287061 - The
@Argumentsstyle in IR test does not work in JDK 21, because the API was added later with JDK-8324641 - The definitions for Membar nodes for IR tests were in different format.
Additional testing:
- [x] New benchmark improves
- [x] New IR test passes with the fix, fails without it
- [x] Linux AArch64 server fastdebug,
all - [x] Linux x86_64 server fastdebug,
all - [x] Linux AArch64 server fastdebug, Maven CTW and Fuzzer tests
- [x] Linux x86_64 server fastdebug, Maven CTW and Fuzzer tests
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8300148 needs maintainer approval
Issue
- JDK-8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit (Enhancement - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2426/head:pull/2426
$ git checkout pull/2426
Update a local copy of the PR:
$ git checkout pull/2426
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2426/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2426
View PR using the GUI difftool:
$ git pr show -t 2426
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2426.diff
:wave: Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
This backport pull request has now been updated with issue from the original commit.
@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Not now, bot.
@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Not now, bot.
@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!