jdk17u-dev
jdk17u-dev copied to clipboard
openjdk
8273153: Consolidate file_exists into os:file_exists
Clean backport to Consolidate file_exists into os:file_exists This backport is required to close this backport clean.
Additional testing in addition to GHA tests
jtreg/tier2
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8273153 needs maintainer approval
Issue
- JDK-8273153: Consolidate file_exists into os:file_exists (Enhancement - P4 - Rejected)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2281/head:pull/2281
$ git checkout pull/2281
Update a local copy of the PR:
$ git checkout pull/2281
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2281/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2281
View PR using the GUI difftool:
$ git pr show -t 2281
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2281.diff
Webrev
:wave: Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval JDK-8273153 request Clean backport to Consolidate file_exists into os:file_exists.This backport is required to close this backport clean. Tier2 and GHA tests passed
@elifaslan1 This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8273153: Consolidate file_exists into os:file_exists
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 198 new commits pushed to the master branch:
- 95f8dc0df2c4bd5d63d05b053ec6541d57ce0876: 8316138: Add GlobalSign 2 TLS root certificates
- 0e524e2f476835885b34e221e64d8e12a9a1d792: 8324243: Compilation failures in java.desktop module with gcc 14
- fed9693f6d956f0cd37478cc186f8316c1ba8b59: 8330815: Use pattern matching for instanceof in KeepAliveCache
- 261ad5e52debe47440270de59683e1ea6cfcc0a9: 8331352: error: template-id not allowed for constructor/destructor in C++20
- d17fa034f72d914f9b2d30fe7eadef80f2159478: 8328997: Remove unnecessary template parameter lists in GrowableArray
- 2440b2422c34c08c324362ce54471241e5e6dd7c: 8319268: Build failure with GCC8.3.1 after 8313643
- 98038b3dfd8984c28a37646de6b1cdaa4c7ae6a3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
- 18bb8dab659f5b57eb0acfa6c18eaaa8ca9ff55f: 8305819: LogConfigurationTest intermittently fails on AArch64
- 0a3445e0b8bb42f0b761f78efbaca33f9433b8e5: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
- db04c7b85eedc089b504a03a6db9163a709e54c3: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
- ... and 188 more: https://git.openjdk.org/jdk17u-dev/compare/f221ff38300b5513a06e5755469668ef83556a3a...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@elifaslan1 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hello @GoeLin , This backport is the first in a backport series that ends in JDK-8316468 There will be total of 3 backports to achieve this backport to be completed. Please see Paul's comment here
@elifaslan1 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
This backport is going to fix a crash seen in Amazon production @GoeLin . I am going to add this to my approval request to pass it to JBS issue.. TIA
/approval JDK-8273153 request Clean backport to Consolidate file_exists into os:file_exists.This backport is required to close this backport clean. This backport is going to fix a crash seen on Amazon Production. Tier2 and GHA tests passed
@elifaslan1 JDK-8273153: Approval has already been requested and rejected.
/approval JDK-8273153 request Clean backport to Consolidate file_exists into os:file_exists.This backport is required to close this backport clean. This backport is going to fix a crash seen on Amazon Production. Tier2 and GHA tests passed
@elifaslan1 Your change (at version 80997abb61316cf86b3a1b6dc8d9b6130d307d0c) is now ready to be sponsored by a Committer.
Going to push as commit 6264c70c66dfa7b90061d8138038c5d1aa022692.
Since your change was applied there have been 198 commits pushed to the master branch:
- 95f8dc0df2c4bd5d63d05b053ec6541d57ce0876: 8316138: Add GlobalSign 2 TLS root certificates
- 0e524e2f476835885b34e221e64d8e12a9a1d792: 8324243: Compilation failures in java.desktop module with gcc 14
- fed9693f6d956f0cd37478cc186f8316c1ba8b59: 8330815: Use pattern matching for instanceof in KeepAliveCache
- 261ad5e52debe47440270de59683e1ea6cfcc0a9: 8331352: error: template-id not allowed for constructor/destructor in C++20
- d17fa034f72d914f9b2d30fe7eadef80f2159478: 8328997: Remove unnecessary template parameter lists in GrowableArray
- 2440b2422c34c08c324362ce54471241e5e6dd7c: 8319268: Build failure with GCC8.3.1 after 8313643
- 98038b3dfd8984c28a37646de6b1cdaa4c7ae6a3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
- 18bb8dab659f5b57eb0acfa6c18eaaa8ca9ff55f: 8305819: LogConfigurationTest intermittently fails on AArch64
- 0a3445e0b8bb42f0b761f78efbaca33f9433b8e5: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
- db04c7b85eedc089b504a03a6db9163a709e54c3: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
- ... and 188 more: https://git.openjdk.org/jdk17u-dev/compare/f221ff38300b5513a06e5755469668ef83556a3a...master
Your commit was automatically rebased without conflicts.
@phohensee @elifaslan1 Pushed as commit 6264c70c66dfa7b90061d8138038c5d1aa022692.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.