jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string

Open xiaotaonan opened this issue 1 year ago • 4 comments
trafficstars

In the scenario of using ZipFileSystem, when getPath("").getFileName() returns null, change getPath("").getNameCount() to 0.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8326487 needs maintainer approval

Issue

  • JDK-8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2242/head:pull/2242
$ git checkout pull/2242

Update a local copy of the PR:
$ git checkout pull/2242
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2242/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2242

View PR using the GUI difftool:
$ git pr show -t 2242

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2242.diff

Webrev

Link to Webrev Comment

xiaotaonan avatar Feb 27 '24 08:02 xiaotaonan

:wave: Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 27 '24 08:02 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Feb 27 '24 08:02 mlbridge[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 19:03 openjdk[bot]

@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 10 '24 21:04 bridgekeeper[bot]

@xiaotaonan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 09 '24 00:05 bridgekeeper[bot]