8324234: Use reserved IP for java.net testing

[luhenry]

trafficstars

Some tests like test/jdk/java/net/Socket/B8312065.java use specific IPs (like 192.168.255.255) taking the assumption that the address is not going to be assigned. This doesn't always hold true, as 192.168.255.255 for example is a valid address.

RFC 5737 defines specific ranges of IP addresses that may are reserved for these exact purpose and that will never be assigned. Let's make sure to use an IP in this range, like 192.0.2.1 for example.

The specific test test/jdk/java/net/Socket/B8312065.java was introduced with https://git.openjdk.org/jdk17u-dev/pull/1639.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8324234 needs maintainer approval

Issue

• JDK-8324234: Use reserved IP for java.net testing (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2149/head:pull/2149
$ git checkout pull/2149

Update a local copy of the PR:
$ git checkout pull/2149
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2149

View PR using the GUI difftool:
$ git pr show -t 2149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2149.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge[bot]]

Webrevs

• 00: Full (1f3cbe4f)

[GoeLin]

2luhenry Reviewi missing. Tests fail. Fix-request comment missing. Removing the tag. Why don't you fix this in head?

[luhenry]

Why don't you fix this in head?

@GoeLin this test only exists on jdk17u, and the whole code was removed in https://github.com/openjdk/jdk/commit/2f3f3b618500b5f112fabca30d4c6780b2a8e723

[luhenry]

@GoeLin could you please let me know if it would be good to get this one integrated? I can also disable the test in Adoptium otherwise, but I would much rather fix it here. Thanks!

[bridgekeeper[bot]]

@luhenry This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[bridgekeeper[bot]]

@luhenry This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@luhenry This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.