8318986: Improve GenericWaitBarrier performance

[shipilev]

trafficstars

Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17.

Additional testing:

• [x] Ad-hoc performance runs, expected improvements
• [x] MacOS AArch64 server fastdebug, tier{1,2,3}

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8318986 needs maintainer approval

Issue

• JDK-8318986: Improve GenericWaitBarrier performance (Enhancement - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2041/head:pull/2041
$ git checkout pull/2041

Update a local copy of the PR:
$ git checkout pull/2041
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2041

View PR using the GUI difftool:
$ git pr show -t 2041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2041.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[bridgekeeper[bot]]

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Not now, bot.

[openjdk[bot]]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318986: Improve GenericWaitBarrier performance

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/approval request Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. Applies cleanly. There is no bugtail in mainline since integration in Nov 2023. tier{1,2,3} tests pass. Risk is medium, as it touches the common code path for non-Linux platforms, but it is also frequently exercised, and thus a breakage would manifest often.

[openjdk[bot]]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk[bot]]

@shipilev 8318986: The approval request has been created successfully.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (6a7c9ca7)
• 00: Full (5db67531)

[shipilev]

GHA failures are environmental.

[bridgekeeper[bot]]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Not now, bot.

[bridgekeeper[bot]]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Not now, bot. We are planning this for October LTS release.

[shipilev]

Re-ran tier{1,2,3} on MacOS AArch64, looks fine.

/integrate

[openjdk[bot]]

Going to push as commit 515bc9a264c1e44cfcada0405a74ab2fba428e10. Since your change was applied there have been 4 commits pushed to the master branch:

• dcb2c35151a846b7c44045235b389baf9713885c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
• 8faeefc1509a5b890bdae852472c318c64dc0772: 8289182: NMT: MemTracker::baseline should return void
• e85eecbea09e68fcac68a39901a58ddf41fa9dbd: 8288568: Reduce runtime of java.security microbenchmarks
• 2d834b36ec68890befc21d93b667d07cbf3c007a: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@shipilev Pushed as commit 515bc9a264c1e44cfcada0405a74ab2fba428e10.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.