jdk17u-dev
jdk17u-dev copied to clipboard
8318078: ADLC: pass ASSERT and PRODUCT flags
Clean backport to make sure the asserts work in .ad files.
Additional testing:
- [x] macos-aarch64-server-fastdebug,
hotspot:tier1 - [ ] linux-aarch64-server-fastdebug,
tier1 - [ ] linux-x86_64-server-fastdebug,
tier1
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8318078 needs maintainer approval
Issue
- JDK-8318078: ADLC: pass ASSERT and PRODUCT flags (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2034/head:pull/2034
$ git checkout pull/2034
Update a local copy of the PR:
$ git checkout pull/2034
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2034/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2034
View PR using the GUI difftool:
$ git pr show -t 2034
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2034.diff
Webrev
:wave: Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
This backport pull request has now been updated with issue from the original commit.
⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Not now, bot.
@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Not now, bot.
@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.