jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8318078: ADLC: pass ASSERT and PRODUCT flags

Open shipilev opened this issue 1 year ago • 11 comments
trafficstars

Clean backport to make sure the asserts work in .ad files.

Additional testing:

  • [x] macos-aarch64-server-fastdebug, hotspot:tier1
  • [ ] linux-aarch64-server-fastdebug, tier1
  • [ ] linux-x86_64-server-fastdebug, tier1

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8318078 needs maintainer approval

Issue

  • JDK-8318078: ADLC: pass ASSERT and PRODUCT flags (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2034/head:pull/2034
$ git checkout pull/2034

Update a local copy of the PR:
$ git checkout pull/2034
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2034

View PR using the GUI difftool:
$ git pr show -t 2034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2034.diff

Webrev

Link to Webrev Comment

shipilev avatar Dec 11 '23 14:12 shipilev

:wave: Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Dec 11 '23 14:12 bridgekeeper[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Dec 11 '23 14:12 openjdk[bot]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Dec 11 '23 14:12 openjdk[bot]

Webrevs

mlbridge[bot] avatar Dec 11 '23 14:12 mlbridge[bot]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jan 08 '24 23:01 bridgekeeper[bot]

Not now, bot.

shipilev avatar Jan 09 '24 08:01 shipilev

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 06 '24 10:02 bridgekeeper[bot]

Not now, bot.

shipilev avatar Feb 06 '24 10:02 shipilev

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 05 '24 12:03 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 19:03 openjdk[bot]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 10 '24 21:04 bridgekeeper[bot]

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 09 '24 00:05 bridgekeeper[bot]