jdk11u-dev
jdk11u-dev copied to clipboard
8327476: Upgrade JLine to 3.26.1
Clean backport of JDK-8327476 from JDK17 that upgrades JLine to 3.26.1 (parity with 11.0.27-oracle). This is tagged as CPU25_04-critical-SQE-OK.
Tested with tier1 tests on Linux...
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
jtreg:test/hotspot/jtreg:tier1 1497 1497 0 0
jtreg:test/jdk:tier1 1899 1899 0 0
jtreg:test/langtools:tier1 3941 3941 0 0
jtreg:test/nashorn:tier1 0 0 0 0
jtreg:test/jaxp:tier1 0 0 0 0
==============================
TEST SUCCESS
And with the following on Linux and Windows 11:
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
jtreg:test/jdk/jdk/internal/jline 3 3 0 0
==============================
TEST SUCCESS
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
jtreg:test/langtools/jdk/jshell 85 85 0 0
==============================
TEST SUCCESS
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8327476 needs maintainer approval
Issue
- JDK-8327476: Upgrade JLine to 3.26.1 (Task - P4 - Requested)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3010/head:pull/3010
$ git checkout pull/3010
Update a local copy of the PR:
$ git checkout pull/3010
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3010/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3010
View PR using the GUI difftool:
$ git pr show -t 3010
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3010.diff
Using Webrev
:wave: Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@vieiro This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8327476: Upgrade JLine to 3.26.1
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 13 new commits pushed to the master branch:
- 657f3cd3e5dea5dead60db45e9e168f8ed0e0b65: Merge
- 13dab160c693baa33af6236792f1cf55de7318b2: 8352097: (tz) zone.tab update missed in 2025a backport
- 690d5953851cd501c58702df4624d2a209a86e4f: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
- ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/ea3a0e4504c9972d666648fd793f85ed4457056b...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
This backport pull request has now been updated with issue from the original commit.
⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
Test failure of ClhsdbFindPC on macos when ran with -XComp (run main/othervm/timeout=480 ClhsdbFindPC true true) is unrelated.
/approval request Please approve this upgrade to JLine to 3.26.1. Low/medium risk. Linux/Windows specific tests pass. This is labelled CPU25_04-critical-SQE-OK but didn't make it to the appropriate 25/04 window for 11 because it required rework on other JDK versions.
@vieiro 8327476: The approval request has been created successfully.
/integrate
@vieiro Your change (at version 604e18f640921b91ed14d77be11052a53ba3a290) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit c4a7b2c304b06245b26765706d53f00dc0238769.
Since your change was applied there have been 16 commits pushed to the master branch:
- 79faa1960335c5bdd7beab7baf29f74fc3243a97: 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment?
- dcc970180a09ff70748285f391a8f3829f64cb69: 8352716: (tz) Update Timezone Data to 2025b
- 5ce10dfe2d1a89e84d59fb40ad0e09ffdf819c74: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
- ... and 13 more: https://git.openjdk.org/jdk11u-dev/compare/ea3a0e4504c9972d666648fd793f85ed4457056b...master
Your commit was automatically rebased without conflicts.
@jerboaa @vieiro Pushed as commit c4a7b2c304b06245b26765706d53f00dc0238769.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.