jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

Open sendaoYan opened this issue 8 months ago • 11 comments

Hi all,

This pull request contains a backport of commit 981d3c2b from the jdk24u openjdk/jdk24u repository to jdk21u-dev repository.

The commit being backported was authored by SendaoYan on 1 Mar 2025.

Thanks!


Progress

  • [ ] JDK-8347629 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3008/head:pull/3008
$ git checkout pull/3008

Update a local copy of the PR:
$ git checkout pull/3008
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3008/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3008

View PR using the GUI difftool:
$ git pr show -t 3008

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3008.diff

Using Webrev

Link to Webrev Comment

sendaoYan avatar Mar 01 '25 04:03 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 01 '25 04:03 bridgekeeper[bot]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 657f3cd3e5dea5dead60db45e9e168f8ed0e0b65: Merge
  • 13dab160c693baa33af6236792f1cf55de7318b2: 8352097: (tz) zone.tab update missed in 2025a backport
  • 690d5953851cd501c58702df4624d2a209a86e4f: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/659a4669208645420e151e78ab5fd3ac3808b310...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 01 '25 04:03 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Mar 01 '25 04:03 openjdk[bot]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Mar 01 '25 04:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 01 '25 04:03 mlbridge[bot]

GHA report 1 test failure:

  1. macos-x64 hs/tier1 serviceability job report Test serviceability/sa/ClhsdbFindPC.java#id1 fails, the intermittent fails has been recorded by https://bugs.openjdk.org/browse/JDK-8249150, it's unrelated to this backport PR.

sendaoYan avatar Mar 02 '25 23:03 sendaoYan

/approval request Clean backport to fix the test bug which maybe cause test fails with -Xcomp option. Change has been verified locally, test-fix only, no risk.

sendaoYan avatar Mar 02 '25 23:03 sendaoYan

@sendaoYan 8347629: The approval request has been created successfully.

openjdk[bot] avatar Mar 02 '25 23:03 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 31 '25 00:03 bridgekeeper[bot]

/approval request Clean backport to fix the test bug which maybe cause test fails with -Xcomp option. Change has been verified locally, test-fix only, no risk. GHA failures are unrelated to this PR.

sendaoYan avatar Mar 31 '25 01:03 sendaoYan

@sendaoYan 8347629: The approval request has been updated successfully.

openjdk[bot] avatar Mar 31 '25 01:03 openjdk[bot]

Thanks for the approved.

/integrate

sendaoYan avatar Apr 13 '25 03:04 sendaoYan

Going to push as commit 1672eb1b5ee486e97fbd20a2d720d51f1b3a2de7. Since your change was applied there have been 18 commits pushed to the master branch:

  • c4a7b2c304b06245b26765706d53f00dc0238769: 8327476: Upgrade JLine to 3.26.1
  • 79faa1960335c5bdd7beab7baf29f74fc3243a97: 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment?
  • dcc970180a09ff70748285f391a8f3829f64cb69: 8352716: (tz) Update Timezone Data to 2025b
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/659a4669208645420e151e78ab5fd3ac3808b310...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Apr 13 '25 03:04 openjdk[bot]

@sendaoYan Pushed as commit 1672eb1b5ee486e97fbd20a2d720d51f1b3a2de7.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Apr 13 '25 03:04 openjdk[bot]