jdk11u-dev
jdk11u-dev copied to clipboard
8350469: [11u] Test AbsPathsInImage.java fails - JDK-8239429 public clone
Hi all,
We observed test build/AbsPathsInImage.java fails which has been recorded by https://github.com/dragonwell-project/dragonwell11/issues/934, and this backport can fix the test bug which cause the test failure.
The test bug which cause this test failure has been fixed by JDK-8239429. But JDK-8239429 is invisible cause JDK-8239429 can not backported directly. So I create a new issue to fix the test bug in jdk11u-dev.
Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8350469 needs maintainer approval
Issue
- JDK-8350469: [11u] Test AbsPathsInImage.java fails - JDK-8239429 public clone (Bug - P4 - Requested)
Reviewers
- Severin Gehwolf (@jerboaa - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2997/head:pull/2997
$ git checkout pull/2997
Update a local copy of the PR:
$ git checkout pull/2997
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2997/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2997
View PR using the GUI difftool:
$ git pr show -t 2997
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2997.diff
Using Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@sendaoYan This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8350469: [11u] Test AbsPathsInImage.java fails - JDK-8239429 public clone
Reviewed-by: sgehwolf
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 24 new commits pushed to the master branch:
- 657f3cd3e5dea5dead60db45e9e168f8ed0e0b65: Merge
- 13dab160c693baa33af6236792f1cf55de7318b2: 8352097: (tz) zone.tab update missed in 2025a backport
- 690d5953851cd501c58702df4624d2a209a86e4f: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
- ... and 21 more: https://git.openjdk.org/jdk11u-dev/compare/8322c66efa9da9210eca7d6081d2a8c2d65ba4e0...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
:warning: @sendaoYan the issue with id 8239429 from commit 5fff0506f9dca6bcfe91992138ceff32d86370a8 does not exist in project JDK.
/label add backport
@sendaoYan
The label backport is not a valid label.
These labels are valid:
/label add infrastructure
@sendaoYan
The label infrastructure is not a valid label.
These labels are valid:
GHA report 1 test failure:
- Test "serviceability/sa/ClhsdbFindPC.java#id1" report "java.io.IOException: App waiting timeout", which has been recorded and fixed by JDK-8249150, it's unralated to this PR.
/label add build
@sendaoYan
The label build is not a valid label.
These labels are valid:
LGTM. Please update the PR title as I've updated the JBS synopsis.
Thanks @jerboaa
/issue JDK-8350469
@sendaoYan This issue is referenced in the PR title - it will now be updated.
⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/label clean
@sendaoYan
The label clean is not a valid label.
These labels are valid:
/approval request Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk.
@sendaoYan 8350469: The approval request has been created successfully.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval request Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk.
@sendaoYan 8350469: The approval request was already up to date.
Thanks for the reviews and approved @jerboaa
/integrate
Going to push as commit ed62438860b6b4205ce91594d34c162e0677b1d6.
Since your change was applied there have been 29 commits pushed to the master branch:
- 1672eb1b5ee486e97fbd20a2d720d51f1b3a2de7: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
- c4a7b2c304b06245b26765706d53f00dc0238769: 8327476: Upgrade JLine to 3.26.1
- 79faa1960335c5bdd7beab7baf29f74fc3243a97: 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment?
- ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/8322c66efa9da9210eca7d6081d2a8c2d65ba4e0...master
Your commit was automatically rebased without conflicts.
@sendaoYan Pushed as commit ed62438860b6b4205ce91594d34c162e0677b1d6.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.