jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8342496: C2/Shenandoah: SEGV in compiled code when running jcstress

Open RadekCap opened this issue 9 months ago • 9 comments

Backport of JDK-8342496 - C2/Shenandoah: SEGV in compiled code when running jcstress

Clean backport. Passed tier 1 tests. Passed gtests.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8342496 needs maintainer approval

Issue

  • JDK-8342496: C2/Shenandoah: SEGV in compiled code when running jcstress (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2995/head:pull/2995
$ git checkout pull/2995

Update a local copy of the PR:
$ git checkout pull/2995
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2995

View PR using the GUI difftool:
$ git pr show -t 2995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2995.diff

Using Webrev

Link to Webrev Comment

RadekCap avatar Feb 14 '25 13:02 RadekCap

:wave: Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 14 '25 13:02 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Feb 14 '25 13:02 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Feb 14 '25 13:02 openjdk[bot]

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Feb 14 '25 13:02 openjdk[bot]

Webrevs

mlbridge[bot] avatar Feb 14 '25 13:02 mlbridge[bot]

@RadekCap Did you run the test without the patch an with it? If so what were the results?

jerboaa avatar Feb 14 '25 14:02 jerboaa

No, because in the bug 11is listed as an affected version.

RadekCap avatar Feb 14 '25 14:02 RadekCap

("It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure." has been removed from the first comment as it was relict from the template which shouldn't be there.)

RadekCap avatar Feb 14 '25 14:02 RadekCap

No, because in the bug 11is listed as an affected version.

Please do so. In fact, it's the least one should do to sanity-check a patch. I'm not sure whether this test has been run on JDK 11. Thanks!

jerboaa avatar Feb 14 '25 14:02 jerboaa

@RadekCap This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 11 '25 20:04 bridgekeeper[bot]