jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8301753: AppendFile/WriteFile has differences between make 3.81 and 4+

Open wkia opened this issue 1 year ago • 15 comments
trafficstars

Clean backport to 11u. This fixes "make test" build problem occured with make version <4.0 in JDK11. The new test is passed locally with a manual run with both "GNU Make 3.82" and "GNU Make 4.3".


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8301753 needs maintainer approval

Issue

  • JDK-8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ (Bug - P4 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2969/head:pull/2969
$ git checkout pull/2969

Update a local copy of the PR:
$ git checkout pull/2969
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2969

View PR using the GUI difftool:
$ git pr show -t 2969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2969.diff

Using Webrev

Link to Webrev Comment

wkia avatar Nov 22 '24 07:11 wkia

:wave: Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Nov 22 '24 07:11 bridgekeeper[bot]

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301753: AppendFile/WriteFile has differences between make 3.81 and 4+

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • 61227856ccd28d887d56d0c93eabd07cf6b026d3: 8348598: Update Libpng to 1.6.47
  • 398ba91d4d0cfbc737992a8414a7bec13fc10182: 8348110: Update LCMS to 2.17
  • 276a157622f76d7210e11423879d81ccd70c3568: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/c99638d35c8aea16eae244d26bc4ab8dcb080788...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Nov 22 '24 07:11 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Nov 22 '24 07:11 openjdk[bot]

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Nov 22 '24 07:11 openjdk[bot]

Webrevs

mlbridge[bot] avatar Nov 22 '24 07:11 mlbridge[bot]

/approval 8301753 request Clean backport to 11u. This fixes "make run-test-prebuilt" build problem occured with make version <4.0 in JDK11.

wkia avatar Nov 22 '24 08:11 wkia

@wkia 8301753: The approval request has been created successfully.

openjdk[bot] avatar Nov 22 '24 08:11 openjdk[bot]

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Dec 20 '24 09:12 bridgekeeper[bot]

@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jan 17 '25 10:01 bridgekeeper[bot]

/open

wkia avatar Jan 28 '25 11:01 wkia

@wkia This pull request is now open

openjdk[bot] avatar Jan 28 '25 11:01 openjdk[bot]

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 25 '25 15:02 bridgekeeper[bot]

@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Mar 25 '25 20:03 bridgekeeper[bot]

/open

wkia avatar Mar 26 '25 10:03 wkia

@wkia This pull request is now open

openjdk[bot] avatar Mar 26 '25 10:03 openjdk[bot]

/integrate

wkia avatar Apr 07 '25 16:04 wkia

@wkia Your change (at version f1edf1767dd1d3e538c29933195316a14415483b) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Apr 07 '25 16:04 openjdk[bot]

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 05 '25 17:05 bridgekeeper[bot]

Up

wkia avatar May 06 '25 05:05 wkia

/sponsor

gnu-andrew avatar May 08 '25 21:05 gnu-andrew

Going to push as commit 0df5d2700d988e7b3745a9a525c81c19719b645c. Since your change was applied there have been 69 commits pushed to the master branch:

  • 61227856ccd28d887d56d0c93eabd07cf6b026d3: 8348598: Update Libpng to 1.6.47
  • 398ba91d4d0cfbc737992a8414a7bec13fc10182: 8348110: Update LCMS to 2.17
  • 276a157622f76d7210e11423879d81ccd70c3568: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/c99638d35c8aea16eae244d26bc4ab8dcb080788...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 08 '25 21:05 openjdk[bot]

@gnu-andrew @wkia Pushed as commit 0df5d2700d988e7b3745a9a525c81c19719b645c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 08 '25 21:05 openjdk[bot]