jdk11u-dev
jdk11u-dev copied to clipboard
8338402: GHA: some of bundles may not get removed
Backport fixing problem, where some bundles may not get removed in GHA.
GHA testing: OK (no leftover bundles, MacOS failures are unrelated)
Progress
- [ ] JDK-8338402 needs maintainer approval
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8338402: GHA: some of bundles may not get removed (Bug - P4 - Requested)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2931/head:pull/2931
$ git checkout pull/2931
Update a local copy of the PR:
$ git checkout pull/2931
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2931/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2931
View PR using the GUI difftool:
$ git pr show -t 2931
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2931.diff
Webrev
:wave: Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@zzambers This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8338402: GHA: some of bundles may not get removed
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 19 new commits pushed to the master branch:
- 59b38591603ccdd6343f5199293c58752c32a8b2: 8340815: Add SECURITY.md file
- dd35f187fd038281ce36b986ef71d3b813c0a83e: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
- b2d385978fca9eb2fd2eb260a72d727d5f0d6740: Merge
- 0358cbd0a1538937612e3a78ffbfb64d7f4c45a2: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
- 934decc1475e5acc00be23c87507274f005780b4: Merge
- 90ad5b18de314faca19e322bb21a4c33cec54785: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
- 6ee8bacfdda51b53178913ebf711ac9feacce26e: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
- ffcdc104058ab2b58d8303f318c2e0ee0dc93a54: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
- 76b8327ba08e2d57b64cd266a3eb3f1a3232a1a5: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
- 8c31358ccc9d07f9512bc56159c85ce465e25135: 8328300: Convert PrintDialogsTest.java from Applet to main program
- ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/3caf5017a11ba0777281c0104dc606873947c615...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
This backport pull request has now been updated with issue from the original commit.
⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Fix to GHA code which removes bundle artifacts, only affects testing in GHA, tested
@zzambers 8338402: The approval request has been created successfully.
/integrate
@zzambers Your change (at version a123266e23254097e989bcbdb3284d54c9f571ba) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit 2232d1f7b497d782edb6fa5f41ec9fd2a90ca33d.
Since your change was applied there have been 22 commits pushed to the master branch:
- 06d87ca65927fa241c8e93cd2ebe4d0d52586e32: 8299254: Support dealing with standard assert macro
- 015796747f05b9c32c2e5a8491d0e149788f9998: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
- bec83f35d6408c9e55f0e442c77019441282b50d: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
- 59b38591603ccdd6343f5199293c58752c32a8b2: 8340815: Add SECURITY.md file
- dd35f187fd038281ce36b986ef71d3b813c0a83e: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
- b2d385978fca9eb2fd2eb260a72d727d5f0d6740: Merge
- 0358cbd0a1538937612e3a78ffbfb64d7f4c45a2: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
- 934decc1475e5acc00be23c87507274f005780b4: Merge
- 90ad5b18de314faca19e322bb21a4c33cec54785: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
- 6ee8bacfdda51b53178913ebf711ac9feacce26e: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
- ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/3caf5017a11ba0777281c0104dc606873947c615...master
Your commit was automatically rebased without conflicts.
@shipilev @zzambers Pushed as commit 2232d1f7b497d782edb6fa5f41ec9fd2a90ca33d.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.