jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore

Open amosshi opened this issue 1 year ago • 6 comments

Backport of JDK-8249836

Testing

  • Local:
  • Pipeline: All passed except macOS
    • macOS: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here The issue exists in all recent PR in jdk11u-dev and not caused by Current PR
  • Testing Machine:

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8249836 needs maintainer approval

Issue

  • JDK-8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2926/head:pull/2926
$ git checkout pull/2926

Update a local copy of the PR:
$ git checkout pull/2926
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2926

View PR using the GUI difftool:
$ git pr show -t 2926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2926.diff

Webrev

Link to Webrev Comment

amosshi avatar Aug 27 '24 03:08 amosshi

:wave: Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 27 '24 03:08 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Aug 27 '24 03:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 27 '24 03:08 openjdk[bot]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 27 '24 03:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 27 '24 03:08 mlbridge[bot]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 24 '24 05:09 bridgekeeper[bot]

@amosshi This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 22 '24 06:10 bridgekeeper[bot]