jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8247706: Unintentional use of new Date(year...) with absolute year

Open amosshi opened this issue 1 year ago • 7 comments

Backport of JDK-8247706

Testing

  • Local: Test passed on MacOS 14.6.1 on Apple M1 Max
    • Passed: java/text/Format/DateFormat/DateFormatRegression.java
    • Passed: java/time/tck/java/time/format/TCKLocalizedPrinterParser.java
    • Passed: java/util/Calendar/FieldStateTest.java
  • Pipeline: All passed except macOS
    • macOS: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here The issue exists in all recent PR in jdk11u-dev and not caused by Current PR
  • Testing Machine: SAP nightlies passed on 2024-09-03
    • Automated jtreg test: jtreg_jdk_tier1 Started at 2024-09-03 09:22:44+01:00
    • java/util/Calendar/FieldStateTest.java: SUCCESSFUL GitHub 📊 - [09:37:01.601 -> 954 msec]

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8247706 needs maintainer approval

Issue

  • JDK-8247706: Unintentional use of new Date(year...) with absolute year (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2924/head:pull/2924
$ git checkout pull/2924

Update a local copy of the PR:
$ git checkout pull/2924
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2924

View PR using the GUI difftool:
$ git pr show -t 2924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2924.diff

Webrev

Link to Webrev Comment

amosshi avatar Aug 27 '24 01:08 amosshi