jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Open cost0much opened this issue 1 year ago • 12 comments

Clean backport that makes TestListenerLeak more robust; already backported to 17 and 21. Passes affected test on Linux x64. MacOS GHA failing due to unrelated deprecated code during compile.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8316193 needs maintainer approval

Issue

  • JDK-8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2923/head:pull/2923
$ git checkout pull/2923

Update a local copy of the PR:
$ git checkout pull/2923
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2923

View PR using the GUI difftool:
$ git pr show -t 2923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2923.diff

Webrev

Link to Webrev Comment

cost0much avatar Aug 26 '24 18:08 cost0much

:wave: Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 26 '24 18:08 bridgekeeper[bot]

@cost0much This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • bec83f35d6408c9e55f0e442c77019441282b50d: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • 59b38591603ccdd6343f5199293c58752c32a8b2: 8340815: Add SECURITY.md file
  • dd35f187fd038281ce36b986ef71d3b813c0a83e: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
  • b2d385978fca9eb2fd2eb260a72d727d5f0d6740: Merge
  • 0358cbd0a1538937612e3a78ffbfb64d7f4c45a2: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 934decc1475e5acc00be23c87507274f005780b4: Merge
  • 90ad5b18de314faca19e322bb21a4c33cec54785: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6ee8bacfdda51b53178913ebf711ac9feacce26e: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ffcdc104058ab2b58d8303f318c2e0ee0dc93a54: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 76b8327ba08e2d57b64cd266a3eb3f1a3232a1a5: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/3df18523abaf771a5ce8981dd3663f4004fefd62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Aug 26 '24 18:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 26 '24 18:08 openjdk[bot]

/approval request Improves the test added in JDK 22. Applies cleanly. Affected test passes. Risk is low: the change is test code only.

cost0much avatar Aug 26 '24 20:08 cost0much

@cost0much 8316193: The approval request has been created successfully.

openjdk[bot] avatar Aug 26 '24 20:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 26 '24 21:08 mlbridge[bot]

There are failed tests.

GoeLin avatar Aug 27 '24 10:08 GoeLin

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 27 '24 10:08 openjdk[bot]

MacOS GHA build failures are sprintf related, i.e., unrelated to this backport.

phohensee avatar Aug 27 '24 15:08 phohensee

/approval request Improves the test added in JDK 22. Applies cleanly. Affected test passes; failing GHA is unrelated to the backport. Risk is low: the change is test code only.

cost0much avatar Aug 27 '24 16:08 cost0much

@cost0much 8316193: The approval request has been updated successfully.

openjdk[bot] avatar Aug 27 '24 16:08 openjdk[bot]

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 24 '24 17:09 bridgekeeper[bot]

/integrate

cost0much avatar Sep 30 '24 15:09 cost0much

@cost0much Your change (at version 3dd91210fbab921790586b3988832465e5e9a09b) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Sep 30 '24 15:09 openjdk[bot]

/sponsor

mrserb avatar Sep 30 '24 16:09 mrserb

Going to push as commit 015796747f05b9c32c2e5a8491d0e149788f9998. Since your change was applied there have been 14 commits pushed to the master branch:

  • bec83f35d6408c9e55f0e442c77019441282b50d: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • 59b38591603ccdd6343f5199293c58752c32a8b2: 8340815: Add SECURITY.md file
  • dd35f187fd038281ce36b986ef71d3b813c0a83e: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
  • b2d385978fca9eb2fd2eb260a72d727d5f0d6740: Merge
  • 0358cbd0a1538937612e3a78ffbfb64d7f4c45a2: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 934decc1475e5acc00be23c87507274f005780b4: Merge
  • 90ad5b18de314faca19e322bb21a4c33cec54785: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6ee8bacfdda51b53178913ebf711ac9feacce26e: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ffcdc104058ab2b58d8303f318c2e0ee0dc93a54: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 76b8327ba08e2d57b64cd266a3eb3f1a3232a1a5: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/3df18523abaf771a5ce8981dd3663f4004fefd62...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 30 '24 16:09 openjdk[bot]

@mrserb @cost0much Pushed as commit 015796747f05b9c32c2e5a8491d0e149788f9998.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 30 '24 16:09 openjdk[bot]