jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8312049: runtime/logging/ClassLoadUnloadTest can be improved

Open cost0much opened this issue 1 year ago • 9 comments

Backport that improves ClassLoadUnloadTest; already backported to JDK21 and JDK17. Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later version, thus these cases are excluded. Some args in exec() also were not added until a later version, thus they are excluded. Additionally, these flags were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes.

MacOS GHA not passing due to unrelated deprecated sprintf


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8312049 needs maintainer approval

Issue

  • JDK-8312049: runtime/logging/ClassLoadUnloadTest can be improved (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2920/head:pull/2920
$ git checkout pull/2920

Update a local copy of the PR:
$ git checkout pull/2920
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2920/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2920

View PR using the GUI difftool:
$ git pr show -t 2920

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2920.diff

Webrev

Link to Webrev Comment

cost0much avatar Aug 23 '24 19:08 cost0much

:wave: Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 23 '24 19:08 bridgekeeper[bot]

@cost0much This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8312049: runtime/logging/ClassLoadUnloadTest can be improved

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • dba357f027f6b6ab361f15f0c50b4e9bdeb5ea66: 8341424: GHA: Collect hs_errs from build time failures
  • bbe28d927803d0c9286cdb1494afa9a267463dd4: 8347965: (tz) Update Timezone Data to 2025a
  • 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
  • 7dab5fef87bd1871c0a0b4872cb8d711bc927dd5: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • 52c8606db4e81b9aa9c55a31e5f401e5e835c714: 8339560: Unaddressed comments during code review of JDK-8337664
  • cde36426cf319f34543abff8afe8d1b3244525d7: 8339931: Update problem list for WindowUpdateFocusabilityTest.java
  • 33d19c4b29fa43ab7bf7feca5f35ee5ddaf5b987: 8195675: Call to insertText with single character from custom Input Method ignored
  • 6a9eb07c209f4f37c6e7b9538a6dad6343f7714f: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1
  • 46ef0f6d7d2ef33366082dbae0ec69cf6caa3540: 8331863: DUIterator_Fast used before it is constructed
  • c67732a5cd062e53add99cbe89cfac346d3bdbec: 8340387: Update OS detection code to recognize Windows Server 2025
  • ... and 68 more: https://git.openjdk.org/jdk11u-dev/compare/828d645208f490b8a74d5e007d37bad7dcad50b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Aug 23 '24 19:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 23 '24 19:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 23 '24 20:08 mlbridge[bot]

MacOS GHA build failures are sprintf related, i.e., not related to this backport.

phohensee avatar Aug 27 '24 15:08 phohensee

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 27 '24 15:08 openjdk[bot]

/approval request Improves the test added by JDK-8312049 in JDK22. Does not apply cleanly, but the manual resolutions are simple and have been investigated. Affected test passes. Risk is low: the change is test code only.

cost0much avatar Aug 27 '24 16:08 cost0much

@cost0much 8312049: The approval request has been created successfully.

openjdk[bot] avatar Aug 27 '24 16:08 openjdk[bot]

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 24 '24 17:09 bridgekeeper[bot]

@cost0much This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 22 '24 23:10 bridgekeeper[bot]

/open

cost0much avatar Feb 20 '25 17:02 cost0much

@cost0much This pull request is now open

openjdk[bot] avatar Feb 20 '25 17:02 openjdk[bot]

/integrate

cost0much avatar Feb 20 '25 17:02 cost0much

@cost0much Your change (at version 7e9fb1f48355cc5203ca832ab569906c3de5cae8) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Feb 20 '25 17:02 openjdk[bot]

/sponsor

phohensee avatar Feb 20 '25 17:02 phohensee

Going to push as commit d158b8baefb0f47991c202fa5eae877a09d37956. Since your change was applied there have been 78 commits pushed to the master branch:

  • dba357f027f6b6ab361f15f0c50b4e9bdeb5ea66: 8341424: GHA: Collect hs_errs from build time failures
  • bbe28d927803d0c9286cdb1494afa9a267463dd4: 8347965: (tz) Update Timezone Data to 2025a
  • 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
  • 7dab5fef87bd1871c0a0b4872cb8d711bc927dd5: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • 52c8606db4e81b9aa9c55a31e5f401e5e835c714: 8339560: Unaddressed comments during code review of JDK-8337664
  • cde36426cf319f34543abff8afe8d1b3244525d7: 8339931: Update problem list for WindowUpdateFocusabilityTest.java
  • 33d19c4b29fa43ab7bf7feca5f35ee5ddaf5b987: 8195675: Call to insertText with single character from custom Input Method ignored
  • 6a9eb07c209f4f37c6e7b9538a6dad6343f7714f: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1
  • 46ef0f6d7d2ef33366082dbae0ec69cf6caa3540: 8331863: DUIterator_Fast used before it is constructed
  • c67732a5cd062e53add99cbe89cfac346d3bdbec: 8340387: Update OS detection code to recognize Windows Server 2025
  • ... and 68 more: https://git.openjdk.org/jdk11u-dev/compare/828d645208f490b8a74d5e007d37bad7dcad50b1...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Feb 20 '25 17:02 openjdk[bot]

@phohensee @cost0much Pushed as commit d158b8baefb0f47991c202fa5eae877a09d37956.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Feb 20 '25 17:02 openjdk[bot]