jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8229822: ThrowingPushPromises tests sometimes fail due to EOF

Open MBaesken opened this issue 1 year ago • 5 comments
trafficstars


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8229822 needs maintainer approval

Issue

  • JDK-8229822: ThrowingPushPromises tests sometimes fail due to EOF (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2895/head:pull/2895
$ git checkout pull/2895

Update a local copy of the PR:
$ git checkout pull/2895
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2895/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2895

View PR using the GUI difftool:
$ git pr show -t 2895

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2895.diff

Webrev

Link to Webrev Comment

MBaesken avatar Aug 02 '24 09:08 MBaesken

:wave: Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 02 '24 09:08 bridgekeeper[bot]

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8229822: ThrowingPushPromises tests sometimes fail due to EOF

SocketTube is fixed to cater for errors caused by pausing/resuming events on an asynchronously closed connection, from within the selector's manager thread. Http2Connection and Stream are fixed to prevent sending a DataFrame on a stream after Reset has been sent.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1daafddfd02f1e01a46bf1228877f6f261ce4c24: 8317343: GC: Make TestHeapFreeRatio use createTestJvm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 02 '24 09:08 openjdk[bot]

This backport pull request has now been updated with issue and summary from the original commit.

openjdk[bot] avatar Aug 02 '24 09:08 openjdk[bot]

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 02 '24 09:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 02 '24 09:08 mlbridge[bot]

/integrate

MBaesken avatar Aug 06 '24 07:08 MBaesken

Going to push as commit 3acdebea8539c12a7a6c6503976e8f74859d2264. Since your change was applied there have been 3 commits pushed to the master branch:

  • c5d2cc138fed05c8dfcd13f6d786dd5c8dae4560: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 7d3469361210546c24715f8c7b7df95e8f876c7b: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 1daafddfd02f1e01a46bf1228877f6f261ce4c24: 8317343: GC: Make TestHeapFreeRatio use createTestJvm

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 06 '24 07:08 openjdk[bot]

@MBaesken Pushed as commit 3acdebea8539c12a7a6c6503976e8f74859d2264.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 06 '24 07:08 openjdk[bot]