jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8328300: Convert PrintDialogsTest.java from Applet to main program

Open luchenlin opened this issue 1 year ago • 4 comments
trafficstars

I backport this for parity with 11.0.25-oracle. text block modified as not supported.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8328300 needs maintainer approval

Issue

  • JDK-8328300: Convert PrintDialogsTest.java from Applet to main program (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2892/head:pull/2892
$ git checkout pull/2892

Update a local copy of the PR:
$ git checkout pull/2892
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2892

View PR using the GUI difftool:
$ git pr show -t 2892

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2892.diff

Webrev

Link to Webrev Comment

luchenlin avatar Aug 01 '24 05:08 luchenlin

:wave: Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 01 '24 05:08 bridgekeeper[bot]

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8328300: Convert PrintDialogsTest.java from Applet to main program

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • ce572dfede792da0eb1b98ac3d8d1df7064dea33: 8339082: Bump update version for OpenJDK: jdk-11.0.26
  • a83d9303d5d1f7f3415436e145ea414b2680f783: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • c67fe36b5fefee554c0d1067f209387606011615: 8325022: Incorrect error message on client authentication
  • 3df18523abaf771a5ce8981dd3663f4004fefd62: 8210338: Better output for GenerationTests.java
  • 9ba9dd276cebd7e0069bc229ed7b5b4db795fb2c: 8224081: SOCKS v4 tests require IPv4
  • d3ce405a142008b2265efdca4fc9b764c877d882: 8206440: Remove javac -source/-target 6 from jdk regression tests
  • 828d645208f490b8a74d5e007d37bad7dcad50b1: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • cd4ae8cc8983642f85648b4e33cd951e04c32320: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
  • cd9e6cb584bfeb232bcea7a642664cb6dd4424f3: 8334166: Enable binary check
  • 3caf5017a11ba0777281c0104dc606873947c615: 8336928: GHA: Bundle artifacts removal broken
  • ... and 17 more: https://git.openjdk.org/jdk11u-dev/compare/de90ed01e11d968853d3da8c3a6f6081f030336b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 01 '24 05:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 01 '24 05:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 01 '24 05:08 mlbridge[bot]

Seems the test is marked manual , did you run it manually , does it work ? @run main/manual PrintDialogsTest

MBaesken avatar Aug 14 '24 10:08 MBaesken

Seems the test is marked manual , did you run it manually , does it work ? @run main/manual PrintDialogsTest hi @MBaesken , yes, local pass.

luchenlin avatar Aug 15 '24 03:08 luchenlin

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 15 '24 07:08 openjdk[bot]

/integrate

luchenlin avatar Sep 02 '24 02:09 luchenlin

Going to push as commit 8c31358ccc9d07f9512bc56159c85ce465e25135. Since your change was applied there have been 27 commits pushed to the master branch:

  • ce572dfede792da0eb1b98ac3d8d1df7064dea33: 8339082: Bump update version for OpenJDK: jdk-11.0.26
  • a83d9303d5d1f7f3415436e145ea414b2680f783: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • c67fe36b5fefee554c0d1067f209387606011615: 8325022: Incorrect error message on client authentication
  • 3df18523abaf771a5ce8981dd3663f4004fefd62: 8210338: Better output for GenerationTests.java
  • 9ba9dd276cebd7e0069bc229ed7b5b4db795fb2c: 8224081: SOCKS v4 tests require IPv4
  • d3ce405a142008b2265efdca4fc9b764c877d882: 8206440: Remove javac -source/-target 6 from jdk regression tests
  • 828d645208f490b8a74d5e007d37bad7dcad50b1: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • cd4ae8cc8983642f85648b4e33cd951e04c32320: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
  • cd9e6cb584bfeb232bcea7a642664cb6dd4424f3: 8334166: Enable binary check
  • 3caf5017a11ba0777281c0104dc606873947c615: 8336928: GHA: Bundle artifacts removal broken
  • ... and 17 more: https://git.openjdk.org/jdk11u-dev/compare/de90ed01e11d968853d3da8c3a6f6081f030336b...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 02 '24 02:09 openjdk[bot]

@luchenlin Pushed as commit 8c31358ccc9d07f9512bc56159c85ce465e25135.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 02 '24 02:09 openjdk[bot]