jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8330523: Reduce runtime and improve efficiency of KeepAliveTest

Open RealCLanger opened this issue 1 year ago • 5 comments

Hi all,

This pull request contains a backport of JDK-8330523, commit 98038b3d from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Christoph Langer on 16 May 2024 and was reviewed by Matthias Baesken.

Thanks!


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8330523 needs maintainer approval

Issue

  • JDK-8330523: Reduce runtime and improve efficiency of KeepAliveTest (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2888/head:pull/2888
$ git checkout pull/2888

Update a local copy of the PR:
$ git checkout pull/2888
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2888

View PR using the GUI difftool:
$ git pr show -t 2888

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2888.diff

Webrev

Link to Webrev Comment

RealCLanger avatar Jul 31 '24 20:07 RealCLanger

:wave: Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 31 '24 21:07 bridgekeeper[bot]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8330523: Reduce runtime and improve efficiency of KeepAliveTest

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 157 new commits pushed to the master branch:

  • 3acdebea8539c12a7a6c6503976e8f74859d2264: 8229822: ThrowingPushPromises tests sometimes fail due to EOF
  • c5d2cc138fed05c8dfcd13f6d786dd5c8dae4560: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 7d3469361210546c24715f8c7b7df95e8f876c7b: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 1daafddfd02f1e01a46bf1228877f6f261ce4c24: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8ef848219bc270b968ca5e9ecdd371973f2debb3: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf0d3005b9d82b49fc1e6455eb30183d3bb: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792bbae576eeaff1c95873ade2d529d514ce: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844b6622b61cca05fd303c461295f9ca6e10: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
  • 95c0b97bc2bfcb686dfabc6d74424772f0f866a1: 8244966: Add .vscode to .hgignore and .gitignore
  • de90ed01e11d968853d3da8c3a6f6081f030336b: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • ... and 147 more: https://git.openjdk.org/jdk11u-dev/compare/2a804f54aa8f921942e98557770446b06c19c1aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 31 '24 21:07 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jul 31 '24 21:07 openjdk[bot]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jul 31 '24 21:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 31 '24 21:07 mlbridge[bot]

/integrate

RealCLanger avatar Aug 07 '24 15:08 RealCLanger

Going to push as commit 648e8f01896b46aa338b1607de70dc1f17706008. Since your change was applied there have been 157 commits pushed to the master branch:

  • 3acdebea8539c12a7a6c6503976e8f74859d2264: 8229822: ThrowingPushPromises tests sometimes fail due to EOF
  • c5d2cc138fed05c8dfcd13f6d786dd5c8dae4560: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 7d3469361210546c24715f8c7b7df95e8f876c7b: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 1daafddfd02f1e01a46bf1228877f6f261ce4c24: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8ef848219bc270b968ca5e9ecdd371973f2debb3: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf0d3005b9d82b49fc1e6455eb30183d3bb: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792bbae576eeaff1c95873ade2d529d514ce: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844b6622b61cca05fd303c461295f9ca6e10: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
  • 95c0b97bc2bfcb686dfabc6d74424772f0f866a1: 8244966: Add .vscode to .hgignore and .gitignore
  • de90ed01e11d968853d3da8c3a6f6081f030336b: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • ... and 147 more: https://git.openjdk.org/jdk11u-dev/compare/2a804f54aa8f921942e98557770446b06c19c1aa...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 07 '24 15:08 openjdk[bot]

@RealCLanger Pushed as commit 648e8f01896b46aa338b1607de70dc1f17706008.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 07 '24 15:08 openjdk[bot]