8336292: [11u] awt_ImagingLib passes arguments to function without a prototype

[vieiro]

This is a fix to JDK-8336292: Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c.

The fix adds disables the deprecated-non-prototype when building with clang, for the build to pass.

This is a 11u only issue, as the make infrastructure was reorganized in JDK-8244044 after OpenJDK 15, and enhanced afterwards. Backporting JDK-8244044 is an important change that should be avoided unless strictly necessary.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [ ] JDK-8336292 needs maintainer approval
• [x] Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #2853 must be integrated first

Issue

• JDK-8336292: [11u] awt_ImagingLib passes arguments to function without a prototype (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2854/head:pull/2854
$ git checkout pull/2854

Update a local copy of the PR:
$ git checkout pull/2854
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2854

View PR using the GUI difftool:
$ git pr show -t 2854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2854.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back vieiro! A progress list of the required criteria for merging this PR into pr/2853 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (fd7dcc99)
• 00: Full (fd7dcc99)

[vieiro]

The GHA macos-13 runner has problems with reverse DNS lookups https://github.com/actions/runner-images/issues/8649, that causes JDI/JDWSP tests to fail.

Modifying /etc/hosts to allow the hostname to be resolved fixes the problem.

[bridgekeeper[bot]]

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vieiro]

Hi @TheRealMDoerr . Thanks for the review. Would it be possible to rerun macos jobs? (I don't have permissions to do that ). Thanks!.

[TheRealMDoerr]

Hi @TheRealMDoerr . Thanks for the review. Would it be possible to rerun macos jobs? (I don't have permissions to do that ). Thanks!.

I can only rerun jobs in my own PRs. You should find a rerun button next to the failing test.

[vieiro]

Thanks, @TheRealMDoerr . I couldn't rerun failed jobs, so I ran the whole workflow. Checks are green now.

I think I'll wait for reviews on the remaining integration blockers/PRs before requesting an approval.

[vieiro]

@GoeLin You're asking why many tests ~~fail~~ may be failing on macos. Here's a short explanation:

• In late june github removed the macos-11 runners, so many jdk builds (21, 17, 11, 8) started hanging.
• The problem was required fixing JDK-8318039 - GHA: Bump macOS and Xcode versions, i.e., bumping the macos github runners to macos-13 / XCode 14.
• This was resolved in jdk-21 and jdk-17
• The backport of JDK-8318039 for 11 is in now place (this PR builds fine with macos-13 GHA runners), but requires this PR (and the other nested PRs/integration blockers) to be reviewed.

Hope this clarifies, Antonio

[openjdk-notifier[bot]]

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

[vieiro]

Parent pull requests have been closed without review, so there's no point in continuing just with this PR.