jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8299378: sprintf is deprecated in Xcode 14

Open vieiro opened this issue 1 year ago • 4 comments
trafficstars

Clean backport of JDK-8299378, as applied to 17.

This replaces the deprecated sprintf with os::snprintf_checked in more places, for the build to progress in the new macos-13 GHA.

The build will still fail until all remaining backports replace sprintfin all places of the codebase.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8299378 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2846 must be integrated first

Issue

  • JDK-8299378: sprintf is deprecated in Xcode 14 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2848/head:pull/2848
$ git checkout pull/2848

Update a local copy of the PR:
$ git checkout pull/2848
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2848

View PR using the GUI difftool:
$ git pr show -t 2848

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2848.diff

Webrev

Link to Webrev Comment

vieiro avatar Jul 10 '24 15:07 vieiro

:wave: Welcome back vieiro! A progress list of the required criteria for merging this PR into pr/2846 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 10 '24 15:07 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jul 10 '24 15:07 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jul 10 '24 15:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 10 '24 20:07 mlbridge[bot]

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 07 '24 20:08 bridgekeeper[bot]

@vieiro This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Sep 04 '24 23:09 bridgekeeper[bot]