jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8228960: [TESTBUG] containers/docker/TestJcmdWithSideCar.java: jcmd reports main class as 'Unknown'

Open vieiro opened this issue 1 year ago • 5 comments

Backport of JDK-8228960 for parity with 11.0.24-oracle This also paves the way for future container-related tests.

Tested on Fedora 40 with Docker version 27.0.1, build 7fafd33

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg/containers/docker/TestJcmdWithSideCar.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

Backport is clean but for a single empty newline in test/hotspot/jtreg/ProblemList.txt, that was introduced by JDK-8228904 (see commit e3aa4909 ) which was not backported to 11.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8228960 needs maintainer approval

Issue

  • JDK-8228960: [TESTBUG] containers/docker/TestJcmdWithSideCar.java: jcmd reports main class as 'Unknown' (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2822/head:pull/2822
$ git checkout pull/2822

Update a local copy of the PR:
$ git checkout pull/2822
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2822

View PR using the GUI difftool:
$ git pr show -t 2822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2822.diff

Webrev

Link to Webrev Comment

vieiro avatar Jun 27 '24 10:06 vieiro

:wave: Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 27 '24 10:06 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jun 27 '24 10:06 openjdk[bot]

This backport pull request has now been updated with issue and summary from the original commit.

openjdk[bot] avatar Jun 27 '24 10:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 27 '24 10:06 mlbridge[bot]

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 25 '24 13:07 bridgekeeper[bot]

@vieiro This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Aug 22 '24 18:08 bridgekeeper[bot]