jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8331142: Add test for number of loader threads in BasicDirectoryModel

Open luchenlin opened this issue 1 year ago • 11 comments

I backport this for parity with 11.0.25-oracle. The test is limit to Windows, so backport with JDK-8331495 together, also backport with the new issue JDK-8331999

threads.addAll(Stream.generate(() -> new Thread(new Scanner(fc))) .limit(NUMBER_OF_THREADS) .toList()); change to as not supported in 11.

threads.addAll(Stream.generate(() -> new Thread(new Scanner(fc))) .limit(NUMBER_OF_THREADS) .collect(Collectors.toList()));


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8331495 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8331142 needs maintainer approval

Issues

  • JDK-8331142: Add test for number of loader threads in BasicDirectoryModel (Bug - P4)
  • JDK-8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2789/head:pull/2789
$ git checkout pull/2789

Update a local copy of the PR:
$ git checkout pull/2789
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2789/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2789

View PR using the GUI difftool:
$ git pr show -t 2789

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2789.diff

Webrev

Link to Webrev Comment

luchenlin avatar Jun 18 '24 08:06 luchenlin