jdk11u-dev
jdk11u-dev copied to clipboard
openjdk
8273153: Consolidate file_exists into os:file_exists
This is not a clean backport. There was a merge conflict on os.cpp due to diverged os::split_path method for this reason os::file_exists method was manually added. This backport is required to address a crash observed in Amazon production.
tier2 tests were run in addition to GHA
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8273153 needs maintainer approval
Issue
- JDK-8273153: Consolidate file_exists into os:file_exists (Enhancement - P4 - Requested)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2721/head:pull/2721
$ git checkout pull/2721
Update a local copy of the PR:
$ git checkout pull/2721
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2721/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2721
View PR using the GUI difftool:
$ git pr show -t 2721
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2721.diff
Webrev
:wave: Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@elifaslan1 This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8273153: Consolidate file_exists into os:file_exists
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 1 new commit pushed to the master branch:
- 8a489e58b37611f4088efe19b2a43a9e54f7866d: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval JDK-8273153 request. This backport is not clean due to diverged os::split_path method.The purpose of this backport is to consolidate file_exists into os:file_exists. It aims to fix a crash observed on Amazon Production. Both Tier 2 and GHA tests passed.
@elifaslan1 Your change (at version 7dbb958c07683fc83e6a242b65518b6b491e62bb) is now ready to be sponsored by a Committer.
Going to push as commit 47fd86ca1c51280629b9f2b86b659c91ffeee22a.
Since your change was applied there has been 1 commit pushed to the master branch:
- 8a489e58b37611f4088efe19b2a43a9e54f7866d: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
Your commit was automatically rebased without conflicts.
@phohensee @elifaslan1 Pushed as commit 47fd86ca1c51280629b9f2b86b659c91ffeee22a.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.