jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

Open vieiro opened this issue 1 year ago • 6 comments

A backport of https://bugs.openjdk.org/browse/JDK-8240226

JDK-8240226 contains a small fix to DeflateIn_InflateOut.java that makes the test pass when --with-zlib=system and the system zlib library is zlib-cloudflare.

This fix is also required for the test to pass in Fedora 40 with the (system wide default) ZLib-ng library.

Tested with both DEBUG and RELEASE builds in Fedora 40.

Let me know if updating the copyright year is required.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8240226 needs maintainer approval

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2719/head:pull/2719
$ git checkout pull/2719

Update a local copy of the PR:
$ git checkout pull/2719
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2719

View PR using the GUI difftool:
$ git pr show -t 2719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2719.diff

vieiro avatar May 21 '24 15:05 vieiro

Hi @vieiro, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user vieiro" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

bridgekeeper[bot] avatar May 21 '24 15:05 bridgekeeper[bot]

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4556aa9d5e42a4afbc6ea749b589d4442e311d24: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 7b377ac0ba396d6a1ca4f80ada2520a7f2c56082: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 31a780d851236a143b7c86f9c7137b67803da9c9: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • c35d30d6fecabcb10cd2011fca39ddee219337b0: 8331263: Bump update version for OpenJDK: jdk-11.0.25
  • 47fd86ca1c51280629b9f2b86b659c91ffeee22a: 8273153: Consolidate file_exists into os:file_exists
  • 8a489e58b37611f4088efe19b2a43a9e54f7866d: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
  • 35333744a8f3cf25c95ee691791b00098dde9a44: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • b7596f3f9d0b442628272459f3f22b3d36634967: 8316138: Add GlobalSign 2 TLS root certificates
  • b8ee2aa15ab538f5a0623b391e1c64e5e63e167a: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar May 21 '24 15:05 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar May 21 '24 15:05 openjdk[bot]

/covered

vieiro avatar May 21 '24 15:05 vieiro

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

bridgekeeper[bot] avatar May 21 '24 15:05 bridgekeeper[bot]

/signed too

vieiro avatar May 21 '24 15:05 vieiro

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar May 29 '24 15:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 29 '24 15:05 mlbridge[bot]

/approval

vieiro avatar May 29 '24 16:05 vieiro

@vieiro usage: /approval [<id>] (request|cancel) [<text>]

openjdk[bot] avatar May 29 '24 16:05 openjdk[bot]

/approval JDK-8240226 request Backport DeflateIn_InflateOut: incorrectly assumes size of zipped file

vieiro avatar May 30 '24 06:05 vieiro

@vieiro JDK-8240226: The approval request has been created successfully.

openjdk[bot] avatar May 30 '24 06:05 openjdk[bot]

/integrate

vieiro avatar Jun 03 '24 06:06 vieiro

@vieiro Your change (at version 4471e60a7cbbb9b83921f091deac3f5f1c9df7d5) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Jun 03 '24 06:06 openjdk[bot]

/sponsor

TheRealMDoerr avatar Jun 03 '24 10:06 TheRealMDoerr

Going to push as commit 69f4ac1e0d61804b1bf306ee728a4de4397aeb47. Since your change was applied there have been 9 commits pushed to the master branch:

  • 4556aa9d5e42a4afbc6ea749b589d4442e311d24: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
  • 7b377ac0ba396d6a1ca4f80ada2520a7f2c56082: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 31a780d851236a143b7c86f9c7137b67803da9c9: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • c35d30d6fecabcb10cd2011fca39ddee219337b0: 8331263: Bump update version for OpenJDK: jdk-11.0.25
  • 47fd86ca1c51280629b9f2b86b659c91ffeee22a: 8273153: Consolidate file_exists into os:file_exists
  • 8a489e58b37611f4088efe19b2a43a9e54f7866d: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
  • 35333744a8f3cf25c95ee691791b00098dde9a44: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • b7596f3f9d0b442628272459f3f22b3d36634967: 8316138: Add GlobalSign 2 TLS root certificates
  • b8ee2aa15ab538f5a0623b391e1c64e5e63e167a: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jun 03 '24 10:06 openjdk[bot]

@TheRealMDoerr @vieiro Pushed as commit 69f4ac1e0d61804b1bf306ee728a4de4397aeb47.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jun 03 '24 10:06 openjdk[bot]

Thank you, @TheRealMDoerr !

vieiro avatar Jun 03 '24 17:06 vieiro