jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8327137: Add test for ConcurrentModificationException in BasicDirectoryModel

Open luchenlin opened this issue 1 year ago • 7 comments
trafficstars

I backport this for parity with 11.0.24-oracle.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8327137 needs maintainer approval

Issue

  • JDK-8327137: Add test for ConcurrentModificationException in BasicDirectoryModel (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2713/head:pull/2713
$ git checkout pull/2713

Update a local copy of the PR:
$ git checkout pull/2713
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2713/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2713

View PR using the GUI difftool:
$ git pr show -t 2713

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2713.diff

Webrev

Link to Webrev Comment

luchenlin avatar May 17 '24 08:05 luchenlin

:wave: Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 17 '24 08:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 17 '24 08:05 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar May 17 '24 08:05 openjdk[bot]

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar May 17 '24 08:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 17 '24 08:05 mlbridge[bot]

ConcurrentModification.java:187: error: ';' expected Records are not supported in JDK 11.

TheRealMDoerr avatar May 20 '24 13:05 TheRealMDoerr

I think we need to postpone this one. JDK-8327137 has related issues which will also need to get ready for backport.

TheRealMDoerr avatar May 21 '24 17:05 TheRealMDoerr

postpone this one due to some related issues.

luchenlin avatar May 27 '24 09:05 luchenlin