jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8328825: Google CAInterop test failures

Open sendaoYan opened this issue 1 year ago • 7 comments

Hi,

Clean backport to fix some of the current failures in CAInterop test.

Additional testing:

  • [x] Affected subtests are now passing

image

Thanks, -sendao


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] JDK-8328825 needs maintainer approval

Issue

  • JDK-8328825: Google CAInterop test failures (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2624/head:pull/2624
$ git checkout pull/2624

Update a local copy of the PR:
$ git checkout pull/2624
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2624

View PR using the GUI difftool:
$ git pr show -t 2624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2624.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Mar 26 '24 01:03 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 26 '24 01:03 bridgekeeper[bot]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8328825: Google CAInterop test failures

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 26 '24 01:03 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Mar 26 '24 01:03 openjdk[bot]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Mar 26 '24 01:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 26 '24 01:03 mlbridge[bot]

/approval request Clean backport to fix some of the current failures in CAInterop test. Affected subtests has been verified.

sendaoYan avatar Mar 27 '24 15:03 sendaoYan

@sendaoYan 8328825: The approval request has been created successfully.

openjdk[bot] avatar Mar 27 '24 15:03 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 09 '24 00:05 bridgekeeper[bot]

Hi, /approval request Clean backport to fix some of the current failures in CAInterop test. Affected subtests has been verified.

sendaoYan avatar May 09 '24 02:05 sendaoYan

@sendaoYan 8328825: Approval has already been requested and approved.

openjdk[bot] avatar May 09 '24 02:05 openjdk[bot]

/integrate

sendaoYan avatar May 13 '24 09:05 sendaoYan

@sendaoYan Your change (at version 4161bdead08fc0c32477362c2f11f9035efdb92b) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 13 '24 09:05 openjdk[bot]

/integrate

sendaoYan avatar May 13 '24 09:05 sendaoYan

@sendaoYan Your change (at version 4161bdead08fc0c32477362c2f11f9035efdb92b) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 13 '24 09:05 openjdk[bot]

/sponsor

TheRealMDoerr avatar May 13 '24 19:05 TheRealMDoerr

Going to push as commit 4714685d6e4bfda3573ae82fa4bfc687460f4b75.

openjdk[bot] avatar May 13 '24 19:05 openjdk[bot]

@TheRealMDoerr @sendaoYan Pushed as commit 4714685d6e4bfda3573ae82fa4bfc687460f4b75.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 13 '24 19:05 openjdk[bot]

/sponsor

Thanks.

sendaoYan avatar May 14 '24 02:05 sendaoYan