8292361: Build failure on PPC64 BE after JDK-8290840

[shipilev]

trafficstars

The only platform where this reproduces seems to be ppc64be. ppc64le builds fine.

* For target hotspot_variant-server_libjvm_objs_abstractInterpreter.o:
In file included from /home/buildbot/worker/build-jdkX-debian11/build/src/hotspot/share/runtime/os.inline.hpp:31,
                 from /home/buildbot/worker/build-jdkX-debian11/build/src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp:37,
                 from /home/buildbot/worker/build-jdkX-debian11/build/src/hotspot/share/asm/macroAssembler.inline.hpp:30,
                 from /home/buildbot/worker/build-jdkX-debian11/build/src/hotspot/share/interpreter/abstractInterpreter.cpp:27:
/home/buildbot/worker/build-jdkX-debian11/build/src/hotspot/os_cpu/linux_ppc/os_linux_ppc.inline.hpp: In static member function 'static void* os::resolve_function_descriptor(void*)':
/home/buildbot/worker/build-jdkX-debian11/build/src/hotspot/os_cpu/linux_ppc/os_linux_ppc.inline.hpp:35:50: error: cannot call member function 'void* os::Linux::resolve_function_descriptor(void*)' without object
   35 |   return os::Linux::resolve_function_descriptor(p);
      |                                                  ^

I think we can make it go away if you make sure that resolve_function_descriptor is universally declared as static. os_aix.hpp and os.hpp already do that. This patch fixes the third declaration.

Additional testing:

• [x] linux-x86_64-server-fastdebug build
• [x] linux-x86_64-zero-fastdebug build
• [x] linux-x86-server-fastdebug build
• [x] linux-aarch64-server-fastdebug cross-build
• [x] linux-arm-server-fastdebug cross-build
• [x] linux-riscv64-server-fastdebug cross-build
• [x] linux-s390x-server-fastdebug cross-build
• [x] linux-ppc64le-server-fastdebug cross-build
• [x] linux-ppc64-server-fastdebug cross-build (now passes)

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8292361: Build failure on PPC64 BE after JDK-8290840

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9876/head:pull/9876
$ git checkout pull/9876

Update a local copy of the PR:
$ git checkout pull/9876
$ git pull https://git.openjdk.org/jdk pull/9876/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9876

View PR using the GUI difftool:
$ git pr show -t 9876

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9876.diff

[bridgekeeper[bot]]

:wave: Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (1e7ae491)

[shipilev]

Paging @iklam ;)

[openjdk[bot]]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292361: Build failure on PPC64 BE after JDK-8290840

Reviewed-by: stefank, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 4cc6cb9d9ddbcc540baac7b81398f2af83f93340: 8290041: ModuleDescriptor.hashCode is inconsistent
• d1edda8ff52e172a85d102d7d5062b9cc401beea: 8292338: aarch64: Use cbnz instruction in gen_continuation_enter when possible
• 21f4eb2233a95be44a5db59b7791cd952ddbd56e: 6521141: DebugGraphics NPE @ setFont();
• 6e6ae596d6bd73909b90911e01fbd0c16f6335e1: 8292286: Convert PlaceholderTable to ResourceHashtable
• ea2c82e74f5580f396920f9e561cbec80c03f373: 8291949: Unexpected extending of SupportedGroups
• b5707b0376660cd8763e46d525ba614b08a59d7b: 8292196: Reduce runtime of java.util.regex microbenchmarks
• b00eedeb029445417f99e8aa4e8fca12e5c69155: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth
• 3a090777bada2e00f573fe8ab113bfa3884982eb: 8291337: Reduce runtime of vm.lamdba microbenchmarks
• dd2034b00725f0fc777c1706b1db898475e89c5c: 8291972: Fix double copy of arguments when thawing two interpreted frames
• aa5b71893307b9fe6137bc3541edccaab73735ac: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
• ... and 4 more: https://git.openjdk.org/jdk/compare/e89abb7d2d902c6e6b3c9953fc6663de10db77b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thank you!

/integrate

[openjdk[bot]]

Going to push as commit ec53fba03933446024028555b87c6023895a5dc6. Since your change was applied there have been 14 commits pushed to the master branch:

• 4cc6cb9d9ddbcc540baac7b81398f2af83f93340: 8290041: ModuleDescriptor.hashCode is inconsistent
• d1edda8ff52e172a85d102d7d5062b9cc401beea: 8292338: aarch64: Use cbnz instruction in gen_continuation_enter when possible
• 21f4eb2233a95be44a5db59b7791cd952ddbd56e: 6521141: DebugGraphics NPE @ setFont();
• 6e6ae596d6bd73909b90911e01fbd0c16f6335e1: 8292286: Convert PlaceholderTable to ResourceHashtable
• ea2c82e74f5580f396920f9e561cbec80c03f373: 8291949: Unexpected extending of SupportedGroups
• b5707b0376660cd8763e46d525ba614b08a59d7b: 8292196: Reduce runtime of java.util.regex microbenchmarks
• b00eedeb029445417f99e8aa4e8fca12e5c69155: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth
• 3a090777bada2e00f573fe8ab113bfa3884982eb: 8291337: Reduce runtime of vm.lamdba microbenchmarks
• dd2034b00725f0fc777c1706b1db898475e89c5c: 8291972: Fix double copy of arguments when thawing two interpreted frames
• aa5b71893307b9fe6137bc3541edccaab73735ac: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
• ... and 4 more: https://git.openjdk.org/jdk/compare/e89abb7d2d902c6e6b3c9953fc6663de10db77b9...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@shipilev Pushed as commit ec53fba03933446024028555b87c6023895a5dc6.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.