jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8291912: Introduce per-allocation target struct for members in G1PLABAllocator

Open tschatzl opened this issue 3 years ago • 3 comments
trafficstars

Hi all,

can I get reviews for this change that refactors the many per-destination arrays in PLABAllocator into an array of struct as I promised in the review for JDK-8288966/PR#9726? I think that makes the code easier to follow since there is less clutter.

Testing: tier1-5, no performance differences

Thanks, Thomas


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #9726 must be integrated first

Issue

  • JDK-8291912: Introduce per-allocation target struct for members in G1PLABAllocator

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9818/head:pull/9818
$ git checkout pull/9818

Update a local copy of the PR:
$ git checkout pull/9818
$ git pull https://git.openjdk.org/jdk pull/9818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9818

View PR using the GUI difftool:
$ git pr show -t 9818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9818.diff

tschatzl avatar Aug 10 '22 09:08 tschatzl

:wave: Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/9726 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 10 '22 09:08 bridgekeeper[bot]

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Aug 10 '22 09:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 10 '22 10:08 mlbridge[bot]

⚠️ @tschatzl This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk[bot] avatar Aug 22 '22 09:08 openjdk[bot]

Closing this because (wrongly) merging with master added lots of unneeded changes making it very hard to review.

tschatzl avatar Aug 22 '22 09:08 tschatzl