8288428: javax/swing/JInternalFrame/Test6505027.java fails frequently in MacOS 12 machines

[manukumarvs]

trafficstars

javax/swing/JInternalFrame/Test6505027.java seems to be unstable in MacOS machines, especially in MacOSX 12 machines and it fails intermittently in CI causing some noise. It seems to be a testbug as adding some stability improvements fix the issue.

Fix: Some stability improvements have been done and the test has been run 10 times per platform in mach5 and got full PASS.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8288428: javax/swing/JInternalFrame/Test6505027.java fails frequently in MacOS 12 machines

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9202/head:pull/9202
$ git checkout pull/9202

Update a local copy of the PR:
$ git checkout pull/9202
$ git pull https://git.openjdk.org/jdk pull/9202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9202

View PR using the GUI difftool:
$ git pr show -t 9202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9202.diff

[bridgekeeper[bot]]

:wave: Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (7995b9b9)

[manukumarvs]

Any volunteers?

[manukumarvs]

Any volunteers please?

[prsadhuk]

I dont see this test failing in our CI systems "frequently"...last time it failed is June8 on a CI system which had some history of config issue, and that too on jdk17 binary and not on mainline..before that it fails on June1 due to some infra issue on mainline..and before that on June19 2021 on jdk11 binary again due to infra issue..so I dont think it's worth tinkering as of now..

also, the test has some quirks as I see. press() method is never called...it uses internal SwingTest class to start the test which I am not sure is needed

[manukumarvs]

I don't see this test failing in our CI systems "frequently"...last time it failed is June8 on a CI system which had some history of config issue, and that too on jdk17 binary and not on mainline..before that it fails on June1 due to some infra issue on mainline..and before that on June19 2021 on jdk11 binary again due to infra issue..so I dont think it's worth tinkering as of now..

also, the test has some quirks as I see. press() method is never called...it uses internal SwingTest class to start the test which I am not sure is needed

I have seen it failing around 18 times last month alone and not all failures were system issues(failures link attached as a confidential comment in bug), but yes, this was mostly failing on JDK18, JDK17 or JDK11 and I think this fails only for MacOS 12 machines. But anyway I felt it better to fix the test if some instability is there.

[manukumarvs]

Any volunteers?

[manukumarvs]

Any volunteers?

[prrace]

How do the changes made here improve stability ? What I see is just that you are adding a new condition under which it will fail.

[bridgekeeper[bot]]

@manukumarvs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@manukumarvs This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.