8352502: Response message is null if expect 100 assertion fails with non 100

[DarraghClarke]

Currently if a request has set Expect-Continue and receives a non 100 response the responseMessage wouldn't be set.

This PR sets responseMessage, it also updates getResponseMessage to check if the message has already been set. This should match the way that responseCode is currently handled.

I also added a test to cover some possible responses.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8352502: Response message is null if expect 100 assertion fails with non 100 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25999/head:pull/25999
$ git checkout pull/25999

Update a local copy of the PR:
$ git checkout pull/25999
$ git pull https://git.openjdk.org/jdk.git pull/25999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25999

View PR using the GUI difftool:
$ git pr show -t 25999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25999.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back dclarke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@DarraghClarke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352502: Response message is null if expect 100 assertion fails with non 100

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 379 new commits pushed to the master branch:

• f95af744b07a9ec87e2507b3d584cbcddc827bbd: 8364312: debug agent should set FD_CLOEXEC flag rather than explicitly closing every open file
• 72d1066ae385ce511a70e762ed68afaa72e96ec4: 8364722: Parallel: Move CLDG mark clearing to the end of full GC
• 0ceb366dc26e2e4f6252da9dd8930b016a5d46ba: 8356645: Javac should utilize new ZIP file system read-only access mode
• ... and 376 more: https://git.openjdk.org/jdk/compare/fea73c1d40441561a246f2a09a739367cfc197ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@DarraghClarke The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (0d826d75)
• 01: Full - Incremental (d6f27780)
• 00: Full (10563157)

[DarraghClarke]

I added salting to the test and some handling on the serverSocket to check for it. I may have overcomplicated the rewrite to include that change so feel free to request more changes

[DarraghClarke]

/integrate

[openjdk[bot]]

Going to push as commit 43cfd80c1c0493f2f50ffd75461ca75a002e0127. Since your change was applied there have been 419 commits pushed to the master branch:

• a60e523f88e7022abe80725b82a8b16a87a377e2: 8349191: Test compiler/ciReplay/TestIncrementalInlining.java failed
• fd766b27b9f862075a415780901c242a7d48c26f: 8364541: Parallel: Support allocation in old generation when heap is almost full
• 8b5bb013557478c9ceb49f94f22600d5901f4eee: 8364987: javac fails with an exception when looking for diamond creation
• ... and 416 more: https://git.openjdk.org/jdk/compare/fea73c1d40441561a246f2a09a739367cfc197ea...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@DarraghClarke Pushed as commit 43cfd80c1c0493f2f50ffd75461ca75a002e0127.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.