8277394: Remove the use of safepoint_workers in reference processor

[tschatzl]

Hi all,

please review this alternate implementation of 8277394. During the review of the first implementation (https://github.com/openjdk/jdk/pull/6453) the reviews did not like that the WorkerThreads were stashed away in the ReferenceProcessor.

This is an alternate implementation that implements the suggestion in the review comments, passing them along through the callers. While this requires a bit more changes, imo it better separates reference processor logic from the execution resources.

Testing: tier1-5

Thanks, Thomas

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8277394: Remove the use of safepoint_workers in reference processor (Enhancement - P4)

Contributors

• Albert Mingkun Yang <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25995/head:pull/25995
$ git checkout pull/25995

Update a local copy of the PR:
$ git checkout pull/25995
$ git pull https://git.openjdk.org/jdk.git pull/25995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25995

View PR using the GUI difftool:
$ git pr show -t 25995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25995.diff

Using Webrev

Link to Webrev Comment

[tschatzl]

/contributor add @albertnetymk

[bridgekeeper[bot]]

:wave: Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277394: Remove the use of safepoint_workers in reference processor

Co-authored-by: Albert Mingkun Yang <[email protected]>
Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• 2528c620a61195ac22d921b168444a7967bf1805: 8361198: [AIX] fix misleading error output in thread_cpu_time_unchecked
• 1be29bd725a4642b841c60c19f2f7f689a360831: 8361060: Keep track of the origin server against which a jdk.internal.net.http.HttpConnection was constructed
• 2f683fdc4a8f9c227e878b0d7fca645fc8abe1b6: 8361037: [ubsan] compiler/c2/irTests/TestFloat16ScalarOperations division by 0
• ... and 77 more: https://git.openjdk.org/jdk/compare/1ca008fd02496dc33e2707c102560cae1690fba5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@tschatzl Contributor Albert Mingkun Yang <[email protected]> successfully added.

[openjdk[bot]]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (9f0058c0)

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews /integrate

[openjdk[bot]]

Going to push as commit 5e40fb6bda1d56e3eba584b49aa0b68096b34169. Since your change was applied there have been 80 commits pushed to the master branch:

• 2528c620a61195ac22d921b168444a7967bf1805: 8361198: [AIX] fix misleading error output in thread_cpu_time_unchecked
• 1be29bd725a4642b841c60c19f2f7f689a360831: 8361060: Keep track of the origin server against which a jdk.internal.net.http.HttpConnection was constructed
• 2f683fdc4a8f9c227e878b0d7fca645fc8abe1b6: 8361037: [ubsan] compiler/c2/irTests/TestFloat16ScalarOperations division by 0
• ... and 77 more: https://git.openjdk.org/jdk/compare/1ca008fd02496dc33e2707c102560cae1690fba5...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@tschatzl Pushed as commit 5e40fb6bda1d56e3eba584b49aa0b68096b34169.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.