8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize

[rgithubli]

Generational shenandoah currently doesn't pick up the changes of managed flag SoftMaxHeapSize when the app is running. This is because the value of _soft_max_capacity in shenandoahGeneration is never changed.

This change delegates the soft max heap size in shenandoahGeneration to ShenandoahGenerationalHeap::heap()->soft_max_capacity(), which does pick up the flag value changes.

Also, found ShenandoahHeap:: initialize uses _num_regions * reg_size_bytes rather than user input flag value. Updated to using actual flag value.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25943/head:pull/25943
$ git checkout pull/25943

Update a local copy of the PR:
$ git checkout pull/25943
$ git pull https://git.openjdk.org/jdk.git pull/25943/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25943

View PR using the GUI difftool:
$ git pr show -t 25943

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25943.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@rgithubli This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize

Reviewed-by: wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 175 new commits pushed to the master branch:

• 91df7978799e5a24a73d8e1ae344e532e572f2dd: 8357915: SecureRandom nextLong memory usage
• 92712ef45dd81fa9f03fbd6427f8c1507f28e62b: 8361367: AOT ExcludedClasses.java test failed with missing constant pool logs
• 5850bf4488ea336c3dd4eafbefb8ade330e2f76a: 8361519: Obsolete Unicode Scalar Value link in Character class
• ... and 172 more: https://git.openjdk.org/jdk/compare/6df0f5e390ecf874c1eca7284c51efa65ce23737...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

@rgithubli The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (8e0b1f21)
• 03: Full - Incremental (503e83ec)
• 02: Full - Incremental (00034259)
• 01: Full - Incremental (49bda04e)
• 00: Full (d5dda920)

[rgithubli]

/integrate

[openjdk[bot]]

@rgithubli Your change (at version 8e0b1f21baf44566b5a6fd96af4fc1baf8bbefa3) is now ready to be sponsored by a Committer.

[earthling-amzn]

/sponsor

[openjdk[bot]]

Going to push as commit fa32bfe11300fdadb35f083037f6ab2a8985d210. Since your change was applied there have been 175 commits pushed to the master branch:

• 91df7978799e5a24a73d8e1ae344e532e572f2dd: 8357915: SecureRandom nextLong memory usage
• 92712ef45dd81fa9f03fbd6427f8c1507f28e62b: 8361367: AOT ExcludedClasses.java test failed with missing constant pool logs
• 5850bf4488ea336c3dd4eafbefb8ade330e2f76a: 8361519: Obsolete Unicode Scalar Value link in Character class
• ... and 172 more: https://git.openjdk.org/jdk/compare/6df0f5e390ecf874c1eca7284c51efa65ce23737...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@earthling-amzn @rgithubli Pushed as commit fa32bfe11300fdadb35f083037f6ab2a8985d210.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.