jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8360206: Refactor ReferenceProcessor::balance_queues

Open albertnetymk opened this issue 5 months ago • 4 comments

Simple refactoring to clean up the inner-loop conditions and control flow. Due to the structural change, the diff is slightly large and may be harder to read than the resulting code. The new version simplifies the logic by using a single remaining_to_move counter in the inner loop to track remaining work, and introduces early returns to reduce indentation and improve clarity.

Test: tier1-3


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8360206: Refactor ReferenceProcessor::balance_queues (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25930/head:pull/25930
$ git checkout pull/25930

Update a local copy of the PR:
$ git checkout pull/25930
$ git pull https://git.openjdk.org/jdk.git pull/25930/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25930

View PR using the GUI difftool:
$ git pr show -t 25930

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25930.diff

Using Webrev

Link to Webrev Comment

albertnetymk avatar Jun 23 '25 08:06 albertnetymk

:wave: Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 23 '25 08:06 bridgekeeper[bot]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360206: Refactor ReferenceProcessor::balance_queues

Reviewed-by: sangheki, kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • aa1911191cf8c2b855268a76baf0757909d66d1b: 8360867: CTW: Disable inline cache verification
  • 00adbbe5538ec5c26dc5bd17ca94cc29db9bc478: 8274051: Remove supports_vtime()/elapsedVTime()
  • c2d76f9844aadf77a0b213a9169a7c5c8c8f1ffb: 8361032: Problem list TestOnSpinWaitAArch64 until JDK-8360936 is fixed
  • ... and 3 more: https://git.openjdk.org/jdk/compare/3525a40f39a966b8592f694a9b3cd4c5dc449266...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jun 23 '25 08:06 openjdk[bot]

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jun 23 '25 08:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 23 '25 08:06 mlbridge[bot]

Thanks for review.

/integrate

albertnetymk avatar Jul 01 '25 10:07 albertnetymk

Going to push as commit fc739fee5360ec052c2b51b3e30ce1c34df71714. Since your change was applied there have been 15 commits pushed to the master branch:

  • aeca49e43fab951c2031895fee32703fb4a19524: 8360791: [ubsan] Adjust signal handling
  • 54c95cf2261f871c47b3700ede31390c8f5e77dd: 8361043: [ubsan] os::print_hex_dump runtime error: applying non-zero offset 8 to null pointer
  • cd6caedd0a3c9ebd4c8c57e64f62b60161c5cd7c: 8360783: CTW: Skip deoptimization between tiers
  • ... and 12 more: https://git.openjdk.org/jdk/compare/3525a40f39a966b8592f694a9b3cd4c5dc449266...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jul 01 '25 10:07 openjdk[bot]

@albertnetymk Pushed as commit fc739fee5360ec052c2b51b3e30ce1c34df71714.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 01 '25 10:07 openjdk[bot]