6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

[prsadhuk]

BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording "Due to an unfortunate set of historical events this method is inappropriately named".

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [x] Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording (Enhancement - P4)

Reviewers

• Damon Nguyen (@DamonGuy - Committer) Review applies to aeed7361
• Abhishek Kumar (@kumarabhi006 - Reviewer) Review applies to aeed7361
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25850/head:pull/25850
$ git checkout pull/25850

Update a local copy of the PR:
$ git checkout pull/25850
$ git pull https://git.openjdk.org/jdk.git pull/25850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25850

View PR using the GUI difftool:
$ git pr show -t 25850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25850.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording

Reviewed-by: aivanov, prr, dnguyen, abhiscxk, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 294 new commits pushed to the master branch:

• f7e8d255cc26fcfb02d51584147751d40fff6478: 8361905: Problem list serviceability/sa/ClhsdbThreadContext.java on Windows due to JDK-8356704
• 26b002805ab235d07998eddd486fe66a69f60671: 8360776: Disable Intel APX by default and enable it with -XX:+UnlockExperimentalVMOptions -XX:+UseAPX in all builds
• 8c00c374ec3e5ae2db3c35a970f6c7a691ae274e: 8361314: Test serviceability/jvmti/VMEvent/MyPackage/VMEventRecursionTest.java FATAL ERROR in native method: Failed during the GetClassSignature call
• ... and 291 more: https://git.openjdk.org/jdk/compare/f62f1178aa01d812ee8ffb1d3dd165b4cf157186...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (800c2d8c)
• 03: Full - Incremental (4cd9caff)
• 02: Full - Incremental (6289a27a)
• 01: Full - Incremental (e29a07be)
• 00: Full (aeed7361)

[kumarabhi006]

CSR?

[honkar-jdk]

@kumarabhi006

CSR?

javadoc change is for a protected method so I think CSR is not required for this change

[aivanov-jdk]

@kumarabhi006

CSR?

javadoc change is for a protected method so I think CSR is not required for this change

A protected method is part of the public API contract, see BasicTextUI.getVisibleEditorRect in Java 24.

However, I say a CSR is not needed because the meaning hasn't changed.

[prrace]

/reviewers 2 reviewer

[prrace]

This may yet need a CSR depending on where the wording ends up.

[openjdk[bot]]

@prrace The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[prsadhuk]

/integrate

[openjdk[bot]]

Going to push as commit bc828c8fb6693760c153a75188f96b1c9d201c8a. Since your change was applied there have been 300 commits pushed to the master branch:

• 917d0182cb5ea6066afd396381ca4650371e64b0: 8361602: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java deadlocks on exception
• 3bacf7ea85f1e3f5e57fd2d046b98dfafe2c7e18: 8361869: Tests which call ThreadController should mark as /native
• 4a351e3e57274df0adee37c472b62f477f75b7b8: 8361328: cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java archive timestamps comparison failed
• ... and 297 more: https://git.openjdk.org/jdk/compare/f62f1178aa01d812ee8ffb1d3dd165b4cf157186...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@prsadhuk Pushed as commit bc828c8fb6693760c153a75188f96b1c9d201c8a.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.