jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8357272: Add overrides for all default methods to wrapper collections

Open stuart-marks opened this issue 5 months ago • 6 comments
trafficstars

This mostly just adds overrides to the wrapper implementations in java.util.Collections. However, in order to satisfy the test, some overrides are also added to ReverseOrderSortedMapView, which is used by the SortedMap wrapper keySet, values, and entrySet views. These overrides don't do anything except to call super, so they're arguably dead code. However, they enable all combinations of sequenced map views to be tested, which is valuable.

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8357272: Add overrides for all default methods to wrapper collections (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25478/head:pull/25478
$ git checkout pull/25478

Update a local copy of the PR:
$ git checkout pull/25478
$ git pull https://git.openjdk.org/jdk.git pull/25478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25478

View PR using the GUI difftool:
$ git pr show -t 25478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25478.diff

Using Webrev

Link to Webrev Comment

stuart-marks avatar May 28 '25 03:05 stuart-marks

:wave: Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 28 '25 03:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 28 '25 03:05 openjdk[bot]

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 28 '25 03:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 25 '25 17:06 mlbridge[bot]

@stuart-marks This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 26 '25 00:06 bridgekeeper[bot]

@bridgekeeper Are you drunk?

stuart-marks avatar Jun 26 '25 16:06 stuart-marks

@stuart-marks This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 04 '25 17:08 bridgekeeper[bot]

/keepalive

stuart-marks avatar Aug 05 '25 17:08 stuart-marks

@stuart-marks The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Aug 05 '25 17:08 openjdk[bot]

@stuart-marks This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 02 '25 22:09 bridgekeeper[bot]

/touch

stuart-marks avatar Sep 02 '25 23:09 stuart-marks

@stuart-marks The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Sep 02 '25 23:09 openjdk[bot]

@stuart-marks This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 01 '25 10:10 bridgekeeper[bot]

/touch

stuart-marks avatar Oct 01 '25 16:10 stuart-marks

@stuart-marks The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Oct 01 '25 16:10 openjdk[bot]

@stuart-marks This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 29 '25 18:10 bridgekeeper[bot]

/touch

stuart-marks avatar Oct 29 '25 22:10 stuart-marks

@stuart-marks The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Oct 29 '25 22:10 openjdk[bot]