jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8350860: Max GC memory overhead tests

Open rgithubli opened this issue 6 months ago • 5 comments
trafficstars

The G1 GC metadata has increased from JDK8 to the current tip. When upgrading JDK for an application from JDK8, applications might observe native memory increases. GC is one of the top contributors. Small applications tend to get impacted more significantly. See sample test in description in https://bugs.openjdk.org/browse/JDK-8350860, when heap is 128m, the native memory used by gc can be over 80m.

In order to make sure we don't bring dramatic native memory increase while developing G1, adding this metadata guardrail test. The test calculates the native memory based on existing GC usages and provides some headroom. When there are significant increase, the test would fail and we should look back to see if the added native memory make sense.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8350860: Max GC memory overhead tests (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24981/head:pull/24981
$ git checkout pull/24981

Update a local copy of the PR:
$ git checkout pull/24981
$ git pull https://git.openjdk.org/jdk.git pull/24981/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24981

View PR using the GUI difftool:
$ git pr show -t 24981

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24981.diff

Using Webrev

Link to Webrev Comment

rgithubli avatar May 01 '25 05:05 rgithubli

:wave: Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 01 '25 05:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 01 '25 05:05 openjdk[bot]

@rgithubli The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 01 '25 05:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 01 '25 05:05 mlbridge[bot]

@rgithubli This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 26 '25 07:06 bridgekeeper[bot]

/keepalive

rgithubli avatar Jun 30 '25 23:06 rgithubli

@rgithubli The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Jun 30 '25 23:06 openjdk[bot]

@rgithubli This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 26 '25 05:08 bridgekeeper[bot]

@rgithubli This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 21 '25 10:10 bridgekeeper[bot]