jdk
jdk copied to clipboard
openjdk
8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux
Having opted in to allow setting an SM is a clearer signal.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21668/head:pull/21668
$ git checkout pull/21668
Update a local copy of the PR:
$ git checkout pull/21668
$ git pull https://git.openjdk.org/jdk.git pull/21668/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21668
View PR using the GUI difftool:
$ git pr show -t 21668
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21668.diff
Webrev
:wave: Welcome back vklang! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@viktorklang-ora The following label will be automatically applied to this pull request:
core-libs
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
The change looks okay but the code will be removed after JEP 486 integrates. So better to re-base for jdk23u, even though this business of setting a SM mid-flight is (and always has been) unpredictable.
