jdk
jdk copied to clipboard
openjdk
8342865: Use type parameter for Class::getPrimitiveClass
Discovered this small cleanup while looking at wrapper class code.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8342865: Use type parameter for Class::getPrimitiveClass (Enhancement - P5)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21653/head:pull/21653
$ git checkout pull/21653
Update a local copy of the PR:
$ git checkout pull/21653
$ git pull https://git.openjdk.org/jdk.git pull/21653/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21653
View PR using the GUI difftool:
$ git pr show -t 21653
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21653.diff
Webrev
:wave: Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@liach This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8342865: Use type parameter for Class::getPrimitiveClass
Reviewed-by: darcy
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@liach The following labels will be automatically applied to this pull request:
core-libsi18n
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
Going to push as commit 40e07a7ea31d04722cda3e6d2fc988df50a7cdca.
Since your change was applied there have been 31 commits pushed to the master branch:
- 9e451aa36586badc7be58804ae6f12e6b671445d: 8343102: Remove
--compressfrom jlink command lines from jpackage tests - 873f8a696fa45c7d94a164be20cf3c797ce7f2a6: 8305406: Add @spec tags in java.base/java.* (part 2)
- 1476f6c47511ad9dceda3633776ace3ee353d7ed: 8343030: RISC-V: Small assembler cleanups
- f1a9a8d25b2e1f9b5dbe8719abb66ec4cd9057dc: 8342902: Deduplication of acquire calls in BindingSpecializer causes escape-analyisis failure
- f1cc890ddfe2e472cf786856dc7d01645f61b054: 8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization
- 36d71735e3554264e8d17f7e0e72999ac639e398: 8339289: Enhance Attach API to support arbitrary length arguments - Windows
- ff165f9f0cf519144d7361b766bcce53d04c518e: 8342934: TYPE_USE annotations printed with error causing "," in toString output
- 0853aee3b377cf9f17340a85f600651db42e6999: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed
- c202a2f7b231152136bd8960c55e43bc96cf1eb9: 8295269: G1: Improve slow startup due to predictor initialization
- 5cbd578fbe9df4f68ab21bf764208ad4f67443f6: 8342930: New tests from JDK-8335912 are failing
- ... and 21 more: https://git.openjdk.org/jdk/compare/25c2f48d458bfd92423c311a887679ad3e1e4041...master
Your commit was automatically rebased without conflicts.
@liach Pushed as commit 40e07a7ea31d04722cda3e6d2fc988df50a7cdca.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.