jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8342838: ECDHE algorithm can't be disabled for TLSv1.3 cipher suites

Open artur-oracle opened this issue 1 year ago • 4 comments

SSLAlgorithmDecomposer.decomposes(CipherSuite.KeyExchange keyExchange) method is missing the null case: TLSv1.3 cipher suites with ECDHE being used for both key exchange and authentication have null for KeyExchange object.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8342838: ECDHE algorithm can't be disabled for TLSv1.3 cipher suites (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21648/head:pull/21648
$ git checkout pull/21648

Update a local copy of the PR:
$ git checkout pull/21648
$ git pull https://git.openjdk.org/jdk.git pull/21648/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21648

View PR using the GUI difftool:
$ git pr show -t 21648

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21648.diff

Webrev

Link to Webrev Comment

artur-oracle avatar Oct 22 '24 20:10 artur-oracle

:wave: Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 22 '24 20:10 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Oct 22 '24 20:10 openjdk[bot]

@artur-oracle The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 22 '24 20:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 22 '24 20:10 mlbridge[bot]