jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8340728: Test vmTestbase/gc/memory/Nio/Nio.java is failing to allocate all direct buffer memory

Open bplb opened this issue 1 year ago • 5 comments
trafficstars

First attempt to allocate VM.maxDirectMemory() bytes of direct buffer memory, decreasing by 1024 bytes for each OutOfMemoryError until allocation succeeds.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8340728: Test vmTestbase/gc/memory/Nio/Nio.java is failing to allocate all direct buffer memory (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21623/head:pull/21623
$ git checkout pull/21623

Update a local copy of the PR:
$ git checkout pull/21623
$ git pull https://git.openjdk.org/jdk.git pull/21623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21623

View PR using the GUI difftool:
$ git pr show -t 21623

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21623.diff

Webrev

Link to Webrev Comment

bplb avatar Oct 21 '24 18:10 bplb

This passed 20 repeats on all CI platforms against an internal build created within the last 24 hours.

bplb avatar Oct 21 '24 18:10 bplb

:wave: Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 21 '24 18:10 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Oct 21 '24 18:10 openjdk[bot]

@bplb The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 21 '24 18:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 21 '24 18:10 mlbridge[bot]

ee76ec1 changes the test to fail if the amount of memory able to be allocated is less than a threshold, in this case,MAX_VM_SIZE - 8*1024. This change passed 30 repeats on all test platforms.

bplb avatar Oct 28 '24 22:10 bplb

/label add nio

bplb avatar Oct 28 '24 22:10 bplb

@bplb The nio label was successfully added.

openjdk[bot] avatar Oct 28 '24 22:10 openjdk[bot]

@bplb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 26 '24 00:11 bridgekeeper[bot]

This request will likely be withdrawn when #22339 is integrated.

bplb avatar Nov 26 '24 16:11 bplb

This request is irrelevant now that #22339 is integrated.

bplb avatar Nov 28 '24 01:11 bplb